[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/26930 )

Change subject: amd/stoneyridge: Set SCI_MAP for SCI enabled GPIOs.
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c
File src/soc/amd/stoneyridge/gpio.c:

https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@236
PS1, Line 236: 
In here you should add a special case, if gpio == 2 and mux == 0 then do the SCI mapping (event 8). This is for wake on LAN.


https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@271
PS1, Line 271: 				sci_map = (uint8_t*)(uintptr_t)(APU_SMI_BASE +
             : 						SMI_SCI_MAP(gevent_num));
             : 
Too complicated. Include soc/southbridge.h and use:
smi_write8(SMI_SCI_MAP(event), event);

I wrote a static function to be called both places:
static void route_sci(uint8_t event)
{
	smi_write8(SMI_SCI_MAP(event), event);
}



-- 
To view, visit https://review.coreboot.org/26930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a
Gerrit-Change-Number: 26930
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 22:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/f3e7550f/attachment.html>