<p><a href="https://review.coreboot.org/26930">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c">File src/soc/amd/stoneyridge/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@236">Patch Set #1, Line 236:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In here you should add a special case, if gpio == 2 and mux == 0 then do the SCI mapping (event 8). This is for wake on LAN.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26930/1/src/soc/amd/stoneyridge/gpio.c@271">Patch Set #1, Line 271:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                               sci_map = (uint8_t*)(uintptr_t)(APU_SMI_BASE +<br>                                                SMI_SCI_MAP(gevent_num));<br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Too complicated. Include soc/southbridge.h and use:<br>smi_write8(SMI_SCI_MAP(event), event);</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">I wrote a static function to be called both places:<br>static void route_sci(uint8_t event)<br>{<br>        smi_write8(SMI_SCI_MAP(event), event);<br>}</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26930">change 26930</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26930"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie7be45264f9bfec56efc47a03071fdb924d16b6a </div>
<div style="display:none"> Gerrit-Change-Number: 26930 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Jun 2018 22:29:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>