[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source

[Daniel Kurtz (Code Review)]

Daniel Kurtz has uploaded this change for review. ( https://review.coreboot.org/26931


Change subject: mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source
......................................................................

mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source

Configuring EC_PCH_WAKE_L as an SCI enabled GPIO allows the EC to wake
the AP from S3 on keyboard presses.

Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>

BUG=b:109759838
TEST=(1) powerd_dbus_suspend
     (2) press a key on the internal keyboard
   => system resumes from S3

Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/26931/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 4a7cfae..28f2293 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -98,7 +98,7 @@
 	PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
 
 	/* GPIO_24 - EC_PCH_WAKE_L */
-	PAD_GPI(GPIO_24, PULL_UP),
+	PAD_SCI(GPIO_24, PULL_UP, EDGE_LOW),
 
 	/* GPIO_26 - APU_PCIE_RST_L */
 	PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),

-- 
To view, visit https://review.coreboot.org/26931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe
Gerrit-Change-Number: 26931
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/28f44ca4/attachment.html>