<p>Daniel Kurtz has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26931">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Configure EC_PCH_WAKE_L as an SCI source<br><br>Configuring EC_PCH_WAKE_L as an SCI enabled GPIO allows the EC to wake<br>the AP from S3 on keyboard presses.<br><br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br><br>BUG=b:109759838<br>TEST=(1) powerd_dbus_suspend<br>     (2) press a key on the internal keyboard<br>   => system resumes from S3<br><br>Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe<br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/26931/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index 4a7cfae..28f2293 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -98,7 +98,7 @@</span><br><span>        PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),</span><br><span> </span><br><span>     /* GPIO_24 - EC_PCH_WAKE_L */</span><br><span style="color: hsl(0, 100%, 40%);">-   PAD_GPI(GPIO_24, PULL_UP),</span><br><span style="color: hsl(120, 100%, 40%);">+    PAD_SCI(GPIO_24, PULL_UP, EDGE_LOW),</span><br><span> </span><br><span>     /* GPIO_26 - APU_PCIE_RST_L */</span><br><span>       PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26931">change 26931</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26931"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I30f72460fd588706f91f4fc3ea4ff007c96e9ebe </div>
<div style="display:none"> Gerrit-Change-Number: 26931 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>