[coreboot-gerrit] Change in coreboot[master]: src/mb/google/poppy: Select right TPM interface

[Naresh Solanki (Code Review)]

Hello Maulik V Vaghela,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/26890

to review the following change.


Change subject: src/mb/google/poppy: Select right TPM interface
......................................................................

src/mb/google/poppy: Select right TPM interface

Except variant atlas, all other variant uses TPM over I2C.

BUG=None
BRANCH=None
TEST=Build for Soraka & make sure that TPM is probed over I2C interface
rather than SPI.

Change-Id: I077e4dc03520e26eb9f6404a7eb1edd99925de77
Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela at intel.com>
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/26890/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index ad08dd4..f26e709 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -13,7 +13,6 @@
 	select MAINBOARD_HAS_CHROMEOS
 	select MAINBOARD_USES_FSP2_0
 	select SOC_INTEL_KABYLAKE
-	select MAINBOARD_HAS_SPI_TPM_CR50
 	select MAINBOARD_HAS_TPM2
 
 if BOARD_GOOGLE_BASEBOARD_POPPY
@@ -142,12 +141,14 @@
 	select DRIVERS_PS2_KEYBOARD
 	select DRIVERS_SPI_ACPI
 	select EXCLUDE_NATIVE_SD_INTERFACE
+	select MAINBOARD_HAS_SPI_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_POPPY
 	def_bool n
 	select DRIVERS_I2C_MAX98927
 	select NO_FADT_8042
 	select VARIANT_HAS_CAMERA_ACPI
+	select MAINBOARD_HAS_I2C_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_NAMI
 	def_bool n
@@ -157,6 +158,7 @@
 	select DRIVERS_PS2_KEYBOARD
 	select DRIVERS_SPI_ACPI
 	select EXCLUDE_NATIVE_SD_INTERFACE
+	select MAINBOARD_HAS_I2C_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_NAUTILUS
 	def_bool n
@@ -165,6 +167,7 @@
 	select DRIVERS_I2C_DA7219
 	select DRIVERS_PS2_KEYBOARD
 	select VARIANT_HAS_CAMERA_ACPI
+	select MAINBOARD_HAS_I2C_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_NOCTURNE
 	def_bool n
@@ -173,12 +176,14 @@
 	select DRIVERS_I2C_DA7219
 	select DRIVERS_SPI_ACPI
 	select EXCLUDE_NATIVE_SD_INTERFACE
+	select MAINBOARD_HAS_I2C_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_SORAKA
 	def_bool n
 	select DRIVERS_I2C_MAX98927
 	select NO_FADT_8042
 	select VARIANT_HAS_CAMERA_ACPI
+	select MAINBOARD_HAS_I2C_TPM_CR50
 
 config VBOOT
 	select EC_GOOGLE_CHROMEEC_SWITCHES

-- 
To view, visit https://review.coreboot.org/26890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I077e4dc03520e26eb9f6404a7eb1edd99925de77
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/b0303924/attachment.html>