<p>Naresh Solanki would like Maulik V Vaghela to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/26890">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mb/google/poppy: Select right TPM interface<br><br>Except variant atlas, all other variant uses TPM over I2C.<br><br>BUG=None<br>BRANCH=None<br>TEST=Build for Soraka & make sure that TPM is probed over I2C interface<br>rather than SPI.<br><br>Change-Id: I077e4dc03520e26eb9f6404a7eb1edd99925de77<br>Signed-off-by: Naresh G Solanki <naresh.solanki@intel.com><br>Signed-off-by: Maulik V Vaghela <maulik.v.vaghela@intel.com><br>---<br>M src/mainboard/google/poppy/Kconfig<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/26890/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig</span><br><span>index ad08dd4..f26e709 100644</span><br><span>--- a/src/mainboard/google/poppy/Kconfig</span><br><span>+++ b/src/mainboard/google/poppy/Kconfig</span><br><span>@@ -13,7 +13,6 @@</span><br><span>         select MAINBOARD_HAS_CHROMEOS</span><br><span>        select MAINBOARD_USES_FSP2_0</span><br><span>         select SOC_INTEL_KABYLAKE</span><br><span style="color: hsl(0, 100%, 40%);">-       select MAINBOARD_HAS_SPI_TPM_CR50</span><br><span>    select MAINBOARD_HAS_TPM2</span><br><span> </span><br><span> if BOARD_GOOGLE_BASEBOARD_POPPY</span><br><span>@@ -142,12 +141,14 @@</span><br><span>     select DRIVERS_PS2_KEYBOARD</span><br><span>  select DRIVERS_SPI_ACPI</span><br><span>      select EXCLUDE_NATIVE_SD_INTERFACE</span><br><span style="color: hsl(120, 100%, 40%);">+    select MAINBOARD_HAS_SPI_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_POPPY</span><br><span>       def_bool n</span><br><span>   select DRIVERS_I2C_MAX98927</span><br><span>  select NO_FADT_8042</span><br><span>  select VARIANT_HAS_CAMERA_ACPI</span><br><span style="color: hsl(120, 100%, 40%);">+        select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_NAMI</span><br><span>        def_bool n</span><br><span>@@ -157,6 +158,7 @@</span><br><span>     select DRIVERS_PS2_KEYBOARD</span><br><span>  select DRIVERS_SPI_ACPI</span><br><span>      select EXCLUDE_NATIVE_SD_INTERFACE</span><br><span style="color: hsl(120, 100%, 40%);">+    select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_NAUTILUS</span><br><span>    def_bool n</span><br><span>@@ -165,6 +167,7 @@</span><br><span>     select DRIVERS_I2C_DA7219</span><br><span>    select DRIVERS_PS2_KEYBOARD</span><br><span>  select VARIANT_HAS_CAMERA_ACPI</span><br><span style="color: hsl(120, 100%, 40%);">+        select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_NOCTURNE</span><br><span>    def_bool n</span><br><span>@@ -173,12 +176,14 @@</span><br><span>   select DRIVERS_I2C_DA7219</span><br><span>    select DRIVERS_SPI_ACPI</span><br><span>      select EXCLUDE_NATIVE_SD_INTERFACE</span><br><span style="color: hsl(120, 100%, 40%);">+    select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_SORAKA</span><br><span>      def_bool n</span><br><span>   select DRIVERS_I2C_MAX98927</span><br><span>  select NO_FADT_8042</span><br><span>  select VARIANT_HAS_CAMERA_ACPI</span><br><span style="color: hsl(120, 100%, 40%);">+        select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span> config VBOOT</span><br><span>        select EC_GOOGLE_CHROMEEC_SWITCHES</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26890">change 26890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I077e4dc03520e26eb9f6404a7eb1edd99925de77 </div>
<div style="display:none"> Gerrit-Change-Number: 26890 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>