[coreboot-gerrit] Change in coreboot[master]: [WIP]sb/intel/common/spi: Add method to probe protected regions
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Wed Jun 6 13:47:45 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26888 )
Change subject: [WIP]sb/intel/common/spi: Add method to probe protected regions
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@1026
PS1, Line 1026: if (IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX)) {
braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@1068
PS1, Line 1068: if (range_entry_base(entry) <= start &&
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/26888
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40812eacba552d9c24790942fc5612b4836238f3
Gerrit-Change-Number: 26888
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 11:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/4c9ac23c/attachment.html>
More information about the coreboot-gerrit
mailing list