<p><a href="https://review.coreboot.org/26888">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c">File src/southbridge/intel/common/spi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@1026">Patch Set #1, Line 1026:</a> <code style="font-family:monospace,monospace">       if (IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26888/1/src/southbridge/intel/common/spi.c@1068">Patch Set #1, Line 1068:</a> <code style="font-family:monospace,monospace">                if (range_entry_base(entry) <= start &&</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that open brace { should be on the previous line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26888">change 26888</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26888"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I40812eacba552d9c24790942fc5612b4836238f3 </div>
<div style="display:none"> Gerrit-Change-Number: 26888 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Jun 2018 11:47:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>