[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Remove Kconfig prompt from SPI_FLASH_SMM

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26872


Change subject: drivers/spi: Remove Kconfig prompt from SPI_FLASH_SMM
......................................................................

drivers/spi: Remove Kconfig prompt from SPI_FLASH_SMM

Why would that be a user visible option? Drop the prompt and the
`default n` and select it automatically when needed. I hope I
caught all its users.

TEST=Confirmed that systems with ELOG_GSMI or DEBUG_SMI compile
     and link.

Change-Id: I44aeec530cc333f4ed4c8cfe67c7b5c9d8fb0049
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/Kconfig
M src/drivers/elog/Kconfig
M src/drivers/spi/Kconfig
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/26872/1

diff --git a/src/Kconfig b/src/Kconfig
index 4c1a0da..0bd8991 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -742,7 +742,7 @@
 	bool "Output verbose SMI debug messages"
 	default n
 	depends on HAVE_SMI_HANDLER
-	select SPI_FLASH_SMM if SPI_CONSOLE
+	select SPI_FLASH_SMM if SPI_CONSOLE || CONSOLE_SPI_FLASH
 	help
 	  This option enables additional SMI related debug messages.
 
diff --git a/src/drivers/elog/Kconfig b/src/drivers/elog/Kconfig
index c7bed75..c5ff7ae 100644
--- a/src/drivers/elog/Kconfig
+++ b/src/drivers/elog/Kconfig
@@ -41,6 +41,7 @@
 config ELOG_GSMI
 	depends on ELOG && SMM_TSEG
 	bool "SMI interface to write and clear event log"
+	select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP
 	default n
 	help
 	  This interface is compatible with the linux kernel driver
diff --git a/src/drivers/spi/Kconfig b/src/drivers/spi/Kconfig
index c8d86ff..b15a502 100644
--- a/src/drivers/spi/Kconfig
+++ b/src/drivers/spi/Kconfig
@@ -62,8 +62,7 @@
 	default y
 
 config SPI_FLASH_SMM
-	bool "SPI flash driver support in SMM"
-	default n
+	bool
 	depends on HAVE_SMI_HANDLER
 	help
 	  Select this option if you want SPI flash support in SMM.

-- 
To view, visit https://review.coreboot.org/26872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44aeec530cc333f4ed4c8cfe67c7b5c9d8fb0049
Gerrit-Change-Number: 26872
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/cc8b2566/attachment-0001.html>