<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26872">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/spi: Remove Kconfig prompt from SPI_FLASH_SMM<br><br>Why would that be a user visible option? Drop the prompt and the<br>`default n` and select it automatically when needed. I hope I<br>caught all its users.<br><br>TEST=Confirmed that systems with ELOG_GSMI or DEBUG_SMI compile<br> and link.<br><br>Change-Id: I44aeec530cc333f4ed4c8cfe67c7b5c9d8fb0049<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/Kconfig<br>M src/drivers/elog/Kconfig<br>M src/drivers/spi/Kconfig<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/26872/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/Kconfig b/src/Kconfig</span><br><span>index 4c1a0da..0bd8991 100644</span><br><span>--- a/src/Kconfig</span><br><span>+++ b/src/Kconfig</span><br><span>@@ -742,7 +742,7 @@</span><br><span> bool "Output verbose SMI debug messages"</span><br><span> default n</span><br><span> depends on HAVE_SMI_HANDLER</span><br><span style="color: hsl(0, 100%, 40%);">- select SPI_FLASH_SMM if SPI_CONSOLE</span><br><span style="color: hsl(120, 100%, 40%);">+ select SPI_FLASH_SMM if SPI_CONSOLE || CONSOLE_SPI_FLASH</span><br><span> help</span><br><span> This option enables additional SMI related debug messages.</span><br><span> </span><br><span>diff --git a/src/drivers/elog/Kconfig b/src/drivers/elog/Kconfig</span><br><span>index c7bed75..c5ff7ae 100644</span><br><span>--- a/src/drivers/elog/Kconfig</span><br><span>+++ b/src/drivers/elog/Kconfig</span><br><span>@@ -41,6 +41,7 @@</span><br><span> config ELOG_GSMI</span><br><span> depends on ELOG && SMM_TSEG</span><br><span> bool "SMI interface to write and clear event log"</span><br><span style="color: hsl(120, 100%, 40%);">+ select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP</span><br><span> default n</span><br><span> help</span><br><span> This interface is compatible with the linux kernel driver</span><br><span>diff --git a/src/drivers/spi/Kconfig b/src/drivers/spi/Kconfig</span><br><span>index c8d86ff..b15a502 100644</span><br><span>--- a/src/drivers/spi/Kconfig</span><br><span>+++ b/src/drivers/spi/Kconfig</span><br><span>@@ -62,8 +62,7 @@</span><br><span> default y</span><br><span> </span><br><span> config SPI_FLASH_SMM</span><br><span style="color: hsl(0, 100%, 40%);">- bool "SPI flash driver support in SMM"</span><br><span style="color: hsl(0, 100%, 40%);">- default n</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span> depends on HAVE_SMI_HANDLER</span><br><span> help</span><br><span> Select this option if you want SPI flash support in SMM.</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26872">change 26872</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26872"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I44aeec530cc333f4ed4c8cfe67c7b5c9d8fb0049 </div>
<div style="display:none"> Gerrit-Change-Number: 26872 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>