[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Set proper dev ops

Naresh Solanki (Code Review) gerrit at coreboot.org
Tue Jun 5 19:25:03 CEST 2018


Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/26869


Change subject: google/chromeec: Set proper dev ops
......................................................................

google/chromeec: Set proper dev ops

For enable_resource & set_resource, use default DEVICE_NOOP so that they
are not reported as missing during enumeration.

BUG=None
BRANCH=None
TEST= Build & boot soraka.

Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210
Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
---
M src/ec/google/chromeec/ec_lpc.c
1 file changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26869/1

diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c
index 42a18e4..3078c22 100644
--- a/src/ec/google/chromeec/ec_lpc.c
+++ b/src/ec/google/chromeec/ec_lpc.c
@@ -459,15 +459,11 @@
 	res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 }
 
-static void lpc_ec_enable_resources(struct device *dev)
-{
-	/* Nothing, but this function avoids an error on serial console. */
-}
-
 static struct device_operations ops = {
 	.init             = lpc_ec_init,
 	.read_resources   = lpc_ec_read_resources,
-	.enable_resources = lpc_ec_enable_resources
+	.enable_resources = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP
 };
 
 static struct pnp_info pnp_dev_info[] = {

-- 
To view, visit https://review.coreboot.org/26869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210
Gerrit-Change-Number: 26869
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/ba804709/attachment-0001.html>


More information about the coreboot-gerrit mailing list