<p>Naresh Solanki has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26869">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/chromeec: Set proper dev ops<br><br>For enable_resource & set_resource, use default DEVICE_NOOP so that they<br>are not reported as missing during enumeration.<br><br>BUG=None<br>BRANCH=None<br>TEST= Build & boot soraka.<br><br>Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210<br>Signed-off-by: Naresh G Solanki <naresh.solanki@intel.com><br>---<br>M src/ec/google/chromeec/ec_lpc.c<br>1 file changed, 2 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/26869/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c</span><br><span>index 42a18e4..3078c22 100644</span><br><span>--- a/src/ec/google/chromeec/ec_lpc.c</span><br><span>+++ b/src/ec/google/chromeec/ec_lpc.c</span><br><span>@@ -459,15 +459,11 @@</span><br><span>     res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void lpc_ec_enable_resources(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        /* Nothing, but this function avoids an error on serial console. */</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static struct device_operations ops = {</span><br><span>      .init             = lpc_ec_init,</span><br><span>     .read_resources   = lpc_ec_read_resources,</span><br><span style="color: hsl(0, 100%, 40%);">-      .enable_resources = lpc_ec_enable_resources</span><br><span style="color: hsl(120, 100%, 40%);">+   .enable_resources = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+      .set_resources    = DEVICE_NOOP</span><br><span> };</span><br><span> </span><br><span> static struct pnp_info pnp_dev_info[] = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26869">change 26869</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26869"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0fcfb8df39c6313c8a5bab5b780a8ffa7531d210 </div>
<div style="display:none"> Gerrit-Change-Number: 26869 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Naresh Solanki <naresh.solanki@intel.com> </div>