[coreboot-gerrit] Change in coreboot[master]: util/sconfig: Add support for multiple device instances

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 )

Change subject: util/sconfig: Add support for multiple device instances
......................................................................


Patch Set 3:

(5 comments)

https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c
File util/sconfig/main.c:

https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@564
PS3, Line 564: 	if (ptr->children || device_has_instance(ptr))
suspect code indent for conditional statements (8, 24)


https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@668
PS3, Line 668: 			fprintf(fil, "\t.pci_irq_info[%d].ioapic_irq_pin = %d,\n",
line over 80 characters


https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@672
PS3, Line 672: 			fprintf(fil, "\t.pci_irq_info[%d].ioapic_dst_id = %d,\n",
line over 80 characters


https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@692
PS3, Line 692: 	fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore);
line over 80 characters


https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@707
PS3, Line 707: 	else if(ptr->children)
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/26800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1
Gerrit-Change-Number: 26800
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 12:08:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/349bed59/attachment.html>