<p><a href="https://review.coreboot.org/26800">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c">File util/sconfig/main.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@564">Patch Set #3, Line 564:</a> <code style="font-family:monospace,monospace">      if (ptr->children || device_has_instance(ptr))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 24)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@668">Patch Set #3, Line 668:</a> <code style="font-family:monospace,monospace">                       fprintf(fil, "\t.pci_irq_info[%d].ioapic_irq_pin = %d,\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@672">Patch Set #3, Line 672:</a> <code style="font-family:monospace,monospace">                   fprintf(fil, "\t.pci_irq_info[%d].ioapic_dst_id = %d,\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@692">Patch Set #3, Line 692:</a> <code style="font-family:monospace,monospace">    fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@707">Patch Set #3, Line 707:</a> <code style="font-family:monospace,monospace"> else if(ptr->children)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26800">change 26800</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26800"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1 </div>
<div style="display:none"> Gerrit-Change-Number: 26800 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:08:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>