[coreboot-gerrit] Change in coreboot[master]: console/hw-debug_sink: Do not cache state of log level

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26832


Change subject: console/hw-debug_sink: Do not cache state of log level
......................................................................

console/hw-debug_sink: Do not cache state of log level

As we suppress output now before console_init() is done, the log level
read at start of ramstage is always -1.

Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
M src/console/hw-debug_sink.adb
1 file changed, 8 insertions(+), 14 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26832/1

diff --git a/src/console/hw-debug_sink.adb b/src/console/hw-debug_sink.adb
index 5a16556..4331b87 100644
--- a/src/console/hw-debug_sink.adb
+++ b/src/console/hw-debug_sink.adb
@@ -19,14 +19,19 @@
 
 package body HW.Debug_Sink is
 
-   Sink_Enabled : Boolean;
+   function console_log_level
+     (msg_level : Interfaces.C.int)
+      return Interfaces.C.int;
+   pragma Import (C, console_log_level, "console_log_level");
+
+   Msg_Level_BIOS_DEBUG : constant := 7;
 
    procedure console_tx_byte (chr : Interfaces.C.char);
    pragma Import (C, console_tx_byte, "console_tx_byte");
 
    procedure Put (Item : String) is
    begin
-      if Sink_Enabled then
+      if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then
          for Idx in Item'Range loop
             console_tx_byte (Interfaces.C.To_C (Item (Idx)));
          end loop;
@@ -35,7 +40,7 @@
 
    procedure Put_Char (Item : Character) is
    begin
-      if Sink_Enabled then
+      if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then
          console_tx_byte (Interfaces.C.To_C (Item));
       end if;
    end Put_Char;
@@ -45,15 +50,4 @@
       Put_Char (Character'Val (16#0a#));
    end New_Line;
 
-   ----------------------------------------------------------------------------
-
-   function console_log_level
-     (msg_level : Interfaces.C.int)
-      return Interfaces.C.int;
-   pragma Import (C, console_log_level, "console_log_level");
-
-   Msg_Level_BIOS_DEBUG : constant := 7;
-
-begin
-   Sink_Enabled := console_log_level (Msg_Level_BIOS_DEBUG) /= 0;
 end HW.Debug_Sink;

-- 
To view, visit https://review.coreboot.org/26832
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538
Gerrit-Change-Number: 26832
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/5327c1b3/attachment.html>