<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26832">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">console/hw-debug_sink: Do not cache state of log level<br><br>As we suppress output now before console_init() is done, the log level<br>read at start of ramstage is always -1.<br><br>Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>---<br>M src/console/hw-debug_sink.adb<br>1 file changed, 8 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/26832/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/console/hw-debug_sink.adb b/src/console/hw-debug_sink.adb</span><br><span>index 5a16556..4331b87 100644</span><br><span>--- a/src/console/hw-debug_sink.adb</span><br><span>+++ b/src/console/hw-debug_sink.adb</span><br><span>@@ -19,14 +19,19 @@</span><br><span> </span><br><span> package body HW.Debug_Sink is</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   Sink_Enabled : Boolean;</span><br><span style="color: hsl(120, 100%, 40%);">+   function console_log_level</span><br><span style="color: hsl(120, 100%, 40%);">+     (msg_level : Interfaces.C.int)</span><br><span style="color: hsl(120, 100%, 40%);">+      return Interfaces.C.int;</span><br><span style="color: hsl(120, 100%, 40%);">+   pragma Import (C, console_log_level, "console_log_level");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   Msg_Level_BIOS_DEBUG : constant := 7;</span><br><span> </span><br><span>    procedure console_tx_byte (chr : Interfaces.C.char);</span><br><span>    pragma Import (C, console_tx_byte, "console_tx_byte");</span><br><span> </span><br><span>    procedure Put (Item : String) is</span><br><span>    begin</span><br><span style="color: hsl(0, 100%, 40%);">-      if Sink_Enabled then</span><br><span style="color: hsl(120, 100%, 40%);">+      if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then</span><br><span>          for Idx in Item'Range loop</span><br><span>             console_tx_byte (Interfaces.C.To_C (Item (Idx)));</span><br><span>          end loop;</span><br><span>@@ -35,7 +40,7 @@</span><br><span> </span><br><span>    procedure Put_Char (Item : Character) is</span><br><span>    begin</span><br><span style="color: hsl(0, 100%, 40%);">-      if Sink_Enabled then</span><br><span style="color: hsl(120, 100%, 40%);">+      if console_log_level (Msg_Level_BIOS_DEBUG) /= 0 then</span><br><span>          console_tx_byte (Interfaces.C.To_C (Item));</span><br><span>       end if;</span><br><span>    end Put_Char;</span><br><span>@@ -45,15 +50,4 @@</span><br><span>       Put_Char (Character'Val (16#0a#));</span><br><span>    end New_Line;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ----------------------------------------------------------------------------</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   function console_log_level</span><br><span style="color: hsl(0, 100%, 40%);">-     (msg_level : Interfaces.C.int)</span><br><span style="color: hsl(0, 100%, 40%);">-      return Interfaces.C.int;</span><br><span style="color: hsl(0, 100%, 40%);">-   pragma Import (C, console_log_level, "console_log_level");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-   Msg_Level_BIOS_DEBUG : constant := 7;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-begin</span><br><span style="color: hsl(0, 100%, 40%);">-   Sink_Enabled := console_log_level (Msg_Level_BIOS_DEBUG) /= 0;</span><br><span> end HW.Debug_Sink;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26832">change 26832</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26832"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia078d647c47aaa41ca9f2df9cf8506148ef86538 </div>
<div style="display:none"> Gerrit-Change-Number: 26832 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>