[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Improve D0F0_DEVEN programming

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Jun 4 09:09:00 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/26798

to look at the new patch set (#3).

Change subject: nb/intel/x4x: Improve D0F0_DEVEN programming
......................................................................

nb/intel/x4x: Improve D0F0_DEVEN programming

According to "Intel 4 Series Chipset Family" enabling or disabling the
EP functions are only meaningful if CAPID[56] and CAPID[57] are both
0. Only set those DEVEN bits when the MCH is capable of it.

Warn if devices are not present in the devicetree.

Add all possible EP functions to the Intel DG43GT devicetree. This
might fix this board not booting with a valid ME (but probably not).

Untested.

Change-Id: I007927e19a8ea716ba6c188a92144325a077c21d
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/intel/dg43gt/devicetree.cb
M src/northbridge/intel/x4x/northbridge.c
2 files changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/26798/3
-- 
To view, visit https://review.coreboot.org/26798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I007927e19a8ea716ba6c188a92144325a077c21d
Gerrit-Change-Number: 26798
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/9a8e8c24/attachment.html>


More information about the coreboot-gerrit mailing list