[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Improve D0F0_DEVEN programming

Patrick Rudolph (Code Review) gerrit at coreboot.org
Mon Jun 4 09:04:05 CEST 2018


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26798 )

Change subject: nb/intel/x4x: Improve D0F0_DEVEN programming
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/26798/2/src/northbridge/intel/x4x/northbridge.c
File src/northbridge/intel/x4x/northbridge.c:

https://review.coreboot.org/#/c/26798/2/src/northbridge/intel/x4x/northbridge.c@196
PS2, Line 196: 	int me_capable = !((pci_read_config32(d0f0, D0F0_CAPID0 + 4)
const int


https://review.coreboot.org/#/c/26798/2/src/northbridge/intel/x4x/northbridge.c@230
PS2, Line 230: 			} else if (!d->enabled) {
d->enabled



-- 
To view, visit https://review.coreboot.org/26798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I007927e19a8ea716ba6c188a92144325a077c21d
Gerrit-Change-Number: 26798
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 07:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/05ebee71/attachment.html>


More information about the coreboot-gerrit mailing list