[coreboot-gerrit] Change in coreboot[master]: util/sconfig: Get rid of unused parameter to walk_device_tree

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon Jun 4 02:49:51 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26801


Change subject: util/sconfig: Get rid of unused parameter to walk_device_tree
......................................................................

util/sconfig: Get rid of unused parameter to walk_device_tree

This change gets rid of unused 3rd parameter chips to the function
walk_device_tree.

BUG=b:80081934
TEST=Verified that abuild compiles successfully for all boards.

Change-Id: I255ff030562073b16310fc22a0981808bf2c062f
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M util/sconfig/main.c
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26801/1

diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index 04ffb98..9a797a6 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -709,8 +709,7 @@
 }
 
 static void walk_device_tree(FILE * fil, struct device *ptr,
-			     void (*func) (FILE *, struct device *),
-			     struct device *chips)
+			     void (*func) (FILE *, struct device *))
 {
 	do {
 		func(fil, ptr);
@@ -848,13 +847,13 @@
 
 	emit_chips(autogen);
 
-	walk_device_tree(autogen, &root, inherit_subsystem_ids, NULL);
+	walk_device_tree(autogen, &root, inherit_subsystem_ids);
 	fprintf(autogen, "\n/* pass 0 */\n");
-	walk_device_tree(autogen, &root, pass0, NULL);
+	walk_device_tree(autogen, &root, pass0);
 	fprintf(autogen, "\n/* pass 1 */\n"
 		"DEVTREE_CONST struct device * DEVTREE_CONST last_dev = &%s;\n",
 		lastnode->name);
-	walk_device_tree(autogen, &root, pass1, NULL);
+	walk_device_tree(autogen, &root, pass1);
 
 	fclose(autogen);
 

-- 
To view, visit https://review.coreboot.org/26801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I255ff030562073b16310fc22a0981808bf2c062f
Gerrit-Change-Number: 26801
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/a7830fb4/attachment-0001.html>


More information about the coreboot-gerrit mailing list