<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26801">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/sconfig: Get rid of unused parameter to walk_device_tree<br><br>This change gets rid of unused 3rd parameter chips to the function<br>walk_device_tree.<br><br>BUG=b:80081934<br>TEST=Verified that abuild compiles successfully for all boards.<br><br>Change-Id: I255ff030562073b16310fc22a0981808bf2c062f<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M util/sconfig/main.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/26801/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/sconfig/main.c b/util/sconfig/main.c</span><br><span>index 04ffb98..9a797a6 100644</span><br><span>--- a/util/sconfig/main.c</span><br><span>+++ b/util/sconfig/main.c</span><br><span>@@ -709,8 +709,7 @@</span><br><span> }</span><br><span> </span><br><span> static void walk_device_tree(FILE * fil, struct device *ptr,</span><br><span style="color: hsl(0, 100%, 40%);">-                      void (*func) (FILE *, struct device *),</span><br><span style="color: hsl(0, 100%, 40%);">-                         struct device *chips)</span><br><span style="color: hsl(120, 100%, 40%);">+                         void (*func) (FILE *, struct device *))</span><br><span> {</span><br><span>    do {</span><br><span>                 func(fil, ptr);</span><br><span>@@ -848,13 +847,13 @@</span><br><span> </span><br><span>  emit_chips(autogen);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        walk_device_tree(autogen, &root, inherit_subsystem_ids, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+    walk_device_tree(autogen, &root, inherit_subsystem_ids);</span><br><span>         fprintf(autogen, "\n/* pass 0 */\n");</span><br><span style="color: hsl(0, 100%, 40%);">- walk_device_tree(autogen, &root, pass0, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+    walk_device_tree(autogen, &root, pass0);</span><br><span>         fprintf(autogen, "\n/* pass 1 */\n"</span><br><span>                "DEVTREE_CONST struct device * DEVTREE_CONST last_dev = &%s;\n",</span><br><span>               lastnode->name);</span><br><span style="color: hsl(0, 100%, 40%);">-     walk_device_tree(autogen, &root, pass1, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+    walk_device_tree(autogen, &root, pass1);</span><br><span> </span><br><span>     fclose(autogen);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26801">change 26801</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26801"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I255ff030562073b16310fc22a0981808bf2c062f </div>
<div style="display:none"> Gerrit-Change-Number: 26801 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>