[coreboot-gerrit] Change in coreboot[master]: sandybridge/raminit_common: use FOR_ALL_CHANNELS macro

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/27733


Change subject: sandybridge/raminit_common: use FOR_ALL_CHANNELS macro
......................................................................

sandybridge/raminit_common: use FOR_ALL_CHANNELS macro

Change-Id: I01bd69605760e8a03787dcfa3da9f47576e3144a
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 8 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/27733/1

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 6639fd9..4de83fb 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -3083,8 +3083,8 @@
 
 	MCHBAR32(0x4cd4) = 0x00000046;
 
-	MCHBAR32_AND_OR(0x400c, 0xFFFFCFFF, 0x1000);
-	MCHBAR32_AND_OR(0x440c, 0xFFFFCFFF, 0x1000);
+	FOR_ALL_CHANNELS
+		MCHBAR32_AND_OR(0x400c + 0x400 * channel, 0xFFFFCFFF, 0x1000);
 
 	if (is_mobile)
 		/* APD - DLL Off, 64 DCLKs until idle, decision per rank */
@@ -3093,8 +3093,9 @@
 		/* APD - PPD, 64 DCLKs until idle, decision per rank */
 		MCHBAR32(PM_PDWN_Config) = 0x00000340;
 
-	MCHBAR32(0x4380) = 0x00000aaa;	// OK
-	MCHBAR32(0x4780) = 0x00000aaa;	// OK
+	FOR_ALL_CHANNELS
+		MCHBAR32(0x4380 + 0x400 * channel) = 0x00000aaa;
+
 	MCHBAR32(0x4f88) = 0x5f7003ff;	// OK
 	MCHBAR32(0x5064) = 0x00073000 | ctrl->reg_5064b0; // OK
 
@@ -3120,8 +3121,9 @@
 	MCHBAR32(0x5880) = 0xca9171e5;
 	MCHBAR32_AND_OR(0x5888, ~0xffffff, 0xe4d5d0);
 	MCHBAR32_AND(0x58a8, ~0x1f);
-	MCHBAR32_AND_OR(0x4294, ~0x30000, 1 << 16);
-	MCHBAR32_AND_OR(0x4694, ~0x30000, 1 << 16);
+
+	FOR_ALL_CHANNELS
+		MCHBAR32_AND_OR(0x4294 + 0x400 * channel, ~0x30000, 1 << 16);
 
 	MCHBAR32(0x5030) |= 1;
 	MCHBAR32(0x5030) |= 0x80;

-- 
To view, visit https://review.coreboot.org/27733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01bd69605760e8a03787dcfa3da9f47576e3144a
Gerrit-Change-Number: 27733
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180730/802c962a/attachment-0001.html>