<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27733">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sandybridge/raminit_common: use FOR_ALL_CHANNELS macro<br><br>Change-Id: I01bd69605760e8a03787dcfa3da9f47576e3144a<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/northbridge/intel/sandybridge/raminit_common.c<br>1 file changed, 8 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/27733/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>index 6639fd9..4de83fb 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>@@ -3083,8 +3083,8 @@</span><br><span> </span><br><span>        MCHBAR32(0x4cd4) = 0x00000046;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      MCHBAR32_AND_OR(0x400c, 0xFFFFCFFF, 0x1000);</span><br><span style="color: hsl(0, 100%, 40%);">-    MCHBAR32_AND_OR(0x440c, 0xFFFFCFFF, 0x1000);</span><br><span style="color: hsl(120, 100%, 40%);">+  FOR_ALL_CHANNELS</span><br><span style="color: hsl(120, 100%, 40%);">+              MCHBAR32_AND_OR(0x400c + 0x400 * channel, 0xFFFFCFFF, 0x1000);</span><br><span> </span><br><span>   if (is_mobile)</span><br><span>               /* APD - DLL Off, 64 DCLKs until idle, decision per rank */</span><br><span>@@ -3093,8 +3093,9 @@</span><br><span>          /* APD - PPD, 64 DCLKs until idle, decision per rank */</span><br><span>              MCHBAR32(PM_PDWN_Config) = 0x00000340;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      MCHBAR32(0x4380) = 0x00000aaa;  // OK</span><br><span style="color: hsl(0, 100%, 40%);">-   MCHBAR32(0x4780) = 0x00000aaa;  // OK</span><br><span style="color: hsl(120, 100%, 40%);">+ FOR_ALL_CHANNELS</span><br><span style="color: hsl(120, 100%, 40%);">+              MCHBAR32(0x4380 + 0x400 * channel) = 0x00000aaa;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   MCHBAR32(0x4f88) = 0x5f7003ff;  // OK</span><br><span>        MCHBAR32(0x5064) = 0x00073000 | ctrl->reg_5064b0; // OK</span><br><span> </span><br><span>@@ -3120,8 +3121,9 @@</span><br><span>       MCHBAR32(0x5880) = 0xca9171e5;</span><br><span>       MCHBAR32_AND_OR(0x5888, ~0xffffff, 0xe4d5d0);</span><br><span>        MCHBAR32_AND(0x58a8, ~0x1f);</span><br><span style="color: hsl(0, 100%, 40%);">-    MCHBAR32_AND_OR(0x4294, ~0x30000, 1 << 16);</span><br><span style="color: hsl(0, 100%, 40%);">-       MCHBAR32_AND_OR(0x4694, ~0x30000, 1 << 16);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   FOR_ALL_CHANNELS</span><br><span style="color: hsl(120, 100%, 40%);">+              MCHBAR32_AND_OR(0x4294 + 0x400 * channel, ~0x30000, 1 << 16);</span><br><span> </span><br><span>      MCHBAR32(0x5030) |= 1;</span><br><span>       MCHBAR32(0x5030) |= 0x80;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27733">change 27733</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27733"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I01bd69605760e8a03787dcfa3da9f47576e3144a </div>
<div style="display:none"> Gerrit-Change-Number: 27733 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>