[coreboot-gerrit] Change in coreboot[master]: mainboard/opencellular/rotundu: Enable TPM 1.2 support

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Sat Jul 28 19:13:41 CEST 2018


Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/27685


Change subject: mainboard/opencellular/rotundu: Enable TPM 1.2 support
......................................................................

mainboard/opencellular/rotundu: Enable TPM 1.2 support

* Enable support for all variants.

Change-Id: Ibdd43d8cff23d3fa1154e2b72aa6095682783fe5
Signed-off-by: Philipp Deppenwiese <zaolin at das-labor.org>
---
M src/mainboard/opencellular/rotundu/Kconfig
M src/mainboard/opencellular/rotundu/acpi_tables.c
M src/mainboard/opencellular/rotundu/variants/rotundu/devicetree.cb
M src/mainboard/opencellular/rotundu/variants/supabrckv1/devicetree.cb
4 files changed, 13 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27685/1

diff --git a/src/mainboard/opencellular/rotundu/Kconfig b/src/mainboard/opencellular/rotundu/Kconfig
index 9b50cef..a062a7a 100644
--- a/src/mainboard/opencellular/rotundu/Kconfig
+++ b/src/mainboard/opencellular/rotundu/Kconfig
@@ -27,6 +27,8 @@
 	select HAVE_ACPI_RESUME
 	select USE_BLOBS
 	select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT
+	select MAINBOARD_HAS_LPC_TPM
+	select MAINBOARD_HAS_TPM1
 
 if BOARD_OPENCELLULAR_BASEBOARD_ROTUNDU
 
diff --git a/src/mainboard/opencellular/rotundu/acpi_tables.c b/src/mainboard/opencellular/rotundu/acpi_tables.c
index eeb9618..4f95bff 100644
--- a/src/mainboard/opencellular/rotundu/acpi_tables.c
+++ b/src/mainboard/opencellular/rotundu/acpi_tables.c
@@ -36,7 +36,7 @@
 	gnvs->s5u1 = 0;
 
 	/* TPM Present */
-	gnvs->tpmp = 0;
+	gnvs->tpmp = 1;
 
 	/* Enable DPTF */
 	gnvs->dpte = 0;
diff --git a/src/mainboard/opencellular/rotundu/variants/rotundu/devicetree.cb b/src/mainboard/opencellular/rotundu/variants/rotundu/devicetree.cb
index a31a001..7eeac7a 100644
--- a/src/mainboard/opencellular/rotundu/variants/rotundu/devicetree.cb
+++ b/src/mainboard/opencellular/rotundu/variants/rotundu/devicetree.cb
@@ -75,7 +75,11 @@
 		device pci 1e.3 on end	# 8086 0F0A -   HSUART 1
 		device pci 1e.4 off end	# 8086 0F0C -   HSUART 2
 		device pci 1e.5 off end	# 8086 0F0E -   SPI
-		device pci 1f.0 on end	# 8086 0F1C - LPC bridge
+		device pci 1f.0 on
+			chip drivers/pc80/tpm
+				device pnp 0c31.0 on end
+			end
+		end	# 8086 0F1C - LPC bridge
 		device pci 1f.3 on end	# 8086 0F12 - SMBus 0
 	end
 end
diff --git a/src/mainboard/opencellular/rotundu/variants/supabrckv1/devicetree.cb b/src/mainboard/opencellular/rotundu/variants/supabrckv1/devicetree.cb
index df08922..c0bd2f0 100644
--- a/src/mainboard/opencellular/rotundu/variants/supabrckv1/devicetree.cb
+++ b/src/mainboard/opencellular/rotundu/variants/supabrckv1/devicetree.cb
@@ -75,7 +75,11 @@
 		device pci 1e.3 on end	# 8086 0F0A -   HSUART 1
 		device pci 1e.4 off end	# 8086 0F0C -   HSUART 2
 		device pci 1e.5 off end	# 8086 0F0E -   SPI
-		device pci 1f.0 on end	# 8086 0F1C - LPC bridge
+		device pci 1f.0 on
+			chip drivers/pc80/tpm
+				device pnp 0c31.0 on end
+			end
+		end	# 8086 0F1C - LPC bridge
 		device pci 1f.3 on end	# 8086 0F12 - SMBus 0
 	end
 end

-- 
To view, visit https://review.coreboot.org/27685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdd43d8cff23d3fa1154e2b72aa6095682783fe5
Gerrit-Change-Number: 27685
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180728/30fc74e5/attachment.html>


More information about the coreboot-gerrit mailing list