[coreboot-gerrit] Change in coreboot[master]: sandybridge/raminit: use MCHBAR32 macro everywhere

Felix Held (Code Review) gerrit at coreboot.org
Sat Jul 28 00:43:01 CEST 2018


Felix Held has uploaded this change for review. ( https://review.coreboot.org/27675


Change subject: sandybridge/raminit: use MCHBAR32 macro everywhere
......................................................................

sandybridge/raminit: use MCHBAR32 macro everywhere

Change-Id: I42d97d278c81ce2cfd0010830c2e0bacddd947d6
Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
M src/northbridge/intel/sandybridge/raminit.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/27675/1

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index e566057..05efa47 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -337,10 +337,10 @@
 
 	wrmsr(0x000002e6, (msr_t) { .lo = 0, .hi = 0 });
 
-	reg_5d10 = read32(DEFAULT_MCHBAR + 0x5d10);	// !!! = 0x00000000
+	reg_5d10 = MCHBAR32(0x5d10);	// !!! = 0x00000000
 	if ((pci_read_config16(SOUTHBRIDGE, 0xa2) & 0xa0) == 0x20	/* 0x0004 */
 	    && reg_5d10 && !s3resume) {
-		write32(DEFAULT_MCHBAR + 0x5d10, 0);
+		MCHBAR32(0x5d10) = 0;
 		/* Need reset.  */
 		outb(0x6, 0xcf9);
 
@@ -442,7 +442,7 @@
 		die("raminit failed");
 
 	/* FIXME: should be hardware revision-dependent.  */
-	write32(DEFAULT_MCHBAR + 0x5024, 0x00a030ce);
+	MCHBAR32(0x5024) = 0x00a030ce;
 
 	set_scrambling_seed(&ctrl);
 

-- 
To view, visit https://review.coreboot.org/27675
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42d97d278c81ce2cfd0010830c2e0bacddd947d6
Gerrit-Change-Number: 27675
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot at felixheld.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/ed5a552d/attachment.html>


More information about the coreboot-gerrit mailing list