<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27675">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sandybridge/raminit: use MCHBAR32 macro everywhere<br><br>Change-Id: I42d97d278c81ce2cfd0010830c2e0bacddd947d6<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/northbridge/intel/sandybridge/raminit.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/27675/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>index e566057..05efa47 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>@@ -337,10 +337,10 @@</span><br><span> </span><br><span>       wrmsr(0x000002e6, (msr_t) { .lo = 0, .hi = 0 });</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    reg_5d10 = read32(DEFAULT_MCHBAR + 0x5d10);     // !!! = 0x00000000</span><br><span style="color: hsl(120, 100%, 40%);">+   reg_5d10 = MCHBAR32(0x5d10);    // !!! = 0x00000000</span><br><span>  if ((pci_read_config16(SOUTHBRIDGE, 0xa2) & 0xa0) == 0x20   /* 0x0004 */</span><br><span>             && reg_5d10 && !s3resume) {</span><br><span style="color: hsl(0, 100%, 40%);">-         write32(DEFAULT_MCHBAR + 0x5d10, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+          MCHBAR32(0x5d10) = 0;</span><br><span>                /* Need reset.  */</span><br><span>           outb(0x6, 0xcf9);</span><br><span> </span><br><span>@@ -442,7 +442,7 @@</span><br><span>          die("raminit failed");</span><br><span> </span><br><span>         /* FIXME: should be hardware revision-dependent.  */</span><br><span style="color: hsl(0, 100%, 40%);">-    write32(DEFAULT_MCHBAR + 0x5024, 0x00a030ce);</span><br><span style="color: hsl(120, 100%, 40%);">+ MCHBAR32(0x5024) = 0x00a030ce;</span><br><span> </span><br><span>   set_scrambling_seed(&ctrl);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27675">change 27675</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27675"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I42d97d278c81ce2cfd0010830c2e0bacddd947d6 </div>
<div style="display:none"> Gerrit-Change-Number: 27675 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>