[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Perform EC init before bootblock gpio configuration

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27671


Change subject: mb/google/octopus: Perform EC init before bootblock gpio configuration
......................................................................

mb/google/octopus: Perform EC init before bootblock gpio configuration

A variant might talk to the EC to get board id in order to identify the
right GPIO configuration. Thus it is important to ensure that the LPC IO
windows are configured before this. This change moves the call to
perform EC init before configuring bootblock GPIOs.

BUG=b:111933657
TEST=Verified that reading board id does not fail on phaser.

Change-Id: Ic23c6fd7597a314e0b6421be39ccc0b1dfb46567
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/bootblock.c
1 file changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/27671/1

diff --git a/src/mainboard/google/octopus/bootblock.c b/src/mainboard/google/octopus/bootblock.c
index 6826e5d..0c239db 100644
--- a/src/mainboard/google/octopus/bootblock.c
+++ b/src/mainboard/google/octopus/bootblock.c
@@ -25,7 +25,14 @@
 	size_t num;
 
 	lpc_configure_pads();
+
+	/*
+	 * Perform EC init before configuring GPIOs. This is because variant
+	 * might talk to the EC to get board id and hence it will require EC
+	 * init to have already performed.
+	 */
+	mainboard_ec_init();
+
 	pads = variant_early_gpio_table(&num);
 	gpio_configure_pads(pads, num);
-	mainboard_ec_init();
 }

-- 
To view, visit https://review.coreboot.org/27671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic23c6fd7597a314e0b6421be39ccc0b1dfb46567
Gerrit-Change-Number: 27671
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/61890195/attachment.html>