<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27671">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Perform EC init before bootblock gpio configuration<br><br>A variant might talk to the EC to get board id in order to identify the<br>right GPIO configuration. Thus it is important to ensure that the LPC IO<br>windows are configured before this. This change moves the call to<br>perform EC init before configuring bootblock GPIOs.<br><br>BUG=b:111933657<br>TEST=Verified that reading board id does not fail on phaser.<br><br>Change-Id: Ic23c6fd7597a314e0b6421be39ccc0b1dfb46567<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/bootblock.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/27671/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/bootblock.c b/src/mainboard/google/octopus/bootblock.c</span><br><span>index 6826e5d..0c239db 100644</span><br><span>--- a/src/mainboard/google/octopus/bootblock.c</span><br><span>+++ b/src/mainboard/google/octopus/bootblock.c</span><br><span>@@ -25,7 +25,14 @@</span><br><span>     size_t num;</span><br><span> </span><br><span>      lpc_configure_pads();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       /*</span><br><span style="color: hsl(120, 100%, 40%);">+     * Perform EC init before configuring GPIOs. This is because variant</span><br><span style="color: hsl(120, 100%, 40%);">+   * might talk to the EC to get board id and hence it will require EC</span><br><span style="color: hsl(120, 100%, 40%);">+   * init to have already performed.</span><br><span style="color: hsl(120, 100%, 40%);">+     */</span><br><span style="color: hsl(120, 100%, 40%);">+   mainboard_ec_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       pads = variant_early_gpio_table(&num);</span><br><span>   gpio_configure_pads(pads, num);</span><br><span style="color: hsl(0, 100%, 40%);">- mainboard_ec_init();</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27671">change 27671</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27671"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic23c6fd7597a314e0b6421be39ccc0b1dfb46567 </div>
<div style="display:none"> Gerrit-Change-Number: 27671 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>