[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu2: correct GPIO and LED setting

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27665 )

Change subject: mb/pcengines/apu2: correct GPIO and LED setting
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/gpio_ftns.c
File src/mainboard/pcengines/apu2/gpio_ftns.c:

https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/gpio_ftns.c@36
PS1, Line 36: 	bdata |= (setting & (GPIO_OUTPUT_ENABLE | GPIO_OUTPUT_VALUE | GPIO_PULL_UP_ENABLE | GPIO_PULL_DOWN_ENABLE));
line over 80 characters


https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/romstage.c
File src/mainboard/pcengines/apu2/romstage.c:

https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/romstage.c@116
PS1, Line 116: 	if (IS_ENABLED(CONFIG_BOARD_PCENGINES_APU5)) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/27665
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4a60acabe65cd7f9985bb3af8bd577764d4196
Gerrit-Change-Number: 27665
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 27 Jul 2018 14:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180727/2e59cad2/attachment.html>