[coreboot-gerrit] Change in coreboot[master]: [test]i945: Fix sdram_rcomp_buffer_strength_and_slew for i945gc

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/27590 )

Change subject: [test]i945: Fix sdram_rcomp_buffer_strength_and_slew for i945gc
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27590/2/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/27590/2/src/northbridge/intel/i945/raminit.c@a965
PS2, Line 965: 
> you change IDX for this option...
in fact for dual channel, we need 2 idx :
the 1st one is for channel0 : idx= 5 * dimm0 + dimm1
and the 2nd for channel1, called idx_channel1 = 5 * dimm2 + dimm3



-- 
To view, visit https://review.coreboot.org/27590
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1705788fdffeacd94fe5e50507733ff7c0f96b
Gerrit-Change-Number: 27590
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 11:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/b1a8a225/attachment.html>