[coreboot-gerrit] Change in coreboot[master]: [test]i945: Fix sdram_rcomp_buffer_strength_and_slew for i945gc

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27590 )

Change subject: [test]i945: Fix sdram_rcomp_buffer_strength_and_slew for i945gc
......................................................................


Patch Set 2:

(1 comment)

Please assume that the code was correct for 945gm (this is pretty well tested) and needs to be adapted for 945gc.

https://review.coreboot.org/#/c/27590/2/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/27590/2/src/northbridge/intel/i945/raminit.c@a965
PS2, Line 965: 
you change IDX for this option...



-- 
To view, visit https://review.coreboot.org/27590
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1705788fdffeacd94fe5e50507733ff7c0f96b
Gerrit-Change-Number: 27590
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 23 Jul 2018 09:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180723/3c16be50/attachment.html>