[coreboot-gerrit] Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas

[Ping-chung Chen (Code Review)]

Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 )

Change subject: mb/google/atlas: MIPI camera ASL files for Atlas
......................................................................


Patch Set 7:

(3 comments)

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@32
PS5, Line 32: 
            : 
> Tab needed
Done


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@62
PS5, Line 62: 
> FCPR naming convention is used to refer that it'a front camera. […]
This is front camera.


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@123
PS5, Line 123: 
> I don't believe SSDB is currently used. Please remove.
Done



-- 
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 7
Gerrit-Owner: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh at intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang at intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen at intel.com>
Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 10 Jul 2018 03:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180710/0f8691f1/attachment.html>