<p><a href="https://review.coreboot.org/27350">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl">File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@32">Patch Set #5, Line 32:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br><br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Tab needed</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@62">Patch Set #5, Line 62:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">FCPR naming convention is used to refer that it'a front camera. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is front camera.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@123">Patch Set #5, Line 123:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't believe SSDB is currently used. Please remove.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27350">change 27350</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27350"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d </div>
<div style="display:none"> Gerrit-Change-Number: 27350 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Ping-chung Chen <ping-chung.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Andy Yeh <andy.yeh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Jul 2018 03:21:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>