[coreboot-gerrit] Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas

[Rajmohan Mani (Code Review)]

Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/27350 )

Change subject: mb/google/atlas: MIPI camera ASL files for Atlas
......................................................................


Patch Set 5:

(8 comments)

mipi_camera.asl - Please align this name with other variants (e.g cam0.asl)

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@43
PS5, Line 43: # FIXME: enable once MIPI is ready
Please remove these comments


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@44
PS5, Line 44: # FIXME: enable once MIPI is ready
Ditto


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl@18
PS5, Line 18: 	/* Define two ports for CIO2 device where endpoint of port0
            : 	is connected to CAM0 and endpoint of port1 is connected to CAM1 */
Please fix these comments as Atlas uses a single camera.


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:

https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@20
PS5, Line 20: INT3478
Where does this ACPI id come from?


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@32
PS5, Line 32: 			AddressingMode7Bit, "\\_SB.PCI0.I2C3",
            : 			0x00, ResourceConsumer, ,
Tab needed


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@45
PS5, Line 45: Sleep(11);
I need to look into the data sheet to understand the timing requirements.
Would be nice if you can add some details about this delay.


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@62
PS5, Line 62: FCPR
FCPR naming convention is used to refer that it'a front camera.
In Atlas, is this a front or rear camera?
Please update all comments about front / rear as needed.


https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@123
PS5, Line 123: SSDB
I don't believe SSDB is currently used. Please remove.



-- 
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 5
Gerrit-Owner: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh at intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang at intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Jul 2018 23:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/0be5fe10/attachment.html>