<p style="white-space: pre-wrap; word-wrap: break-word;">mipi_camera.asl - Please align this name with other variants (e.g cam0.asl)</p><p><a href="https://review.coreboot.org/27350">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb">File src/mainboard/google/poppy/variants/atlas/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@43">Patch Set #5, Line 43:</a> <code style="font-family:monospace,monospace"># FIXME: enable once MIPI is ready</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please remove these comments</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/devicetree.cb@44">Patch Set #5, Line 44:</a> <code style="font-family:monospace,monospace"># FIXME: enable once MIPI is ready</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ditto</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl">File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl@18">Patch Set #5, Line 18:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /* Define two ports for CIO2 device where endpoint of port0<br>   is connected to CAM0 and endpoint of port1 is connected to CAM1 */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please fix these comments as Atlas uses a single camera.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl">File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@20">Patch Set #5, Line 20:</a> <code style="font-family:monospace,monospace">INT3478</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Where does this ACPI id come from?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@32">Patch Set #5, Line 32:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                 AddressingMode7Bit, "\\_SB.PCI0.I2C3",<br>                      0x00, ResourceConsumer, ,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Tab needed</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@45">Patch Set #5, Line 45:</a> <code style="font-family:monospace,monospace">Sleep(11);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I need to look into the data sheet to understand the timing requirements.<br>Would be nice if you can add some details about this delay.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@62">Patch Set #5, Line 62:</a> <code style="font-family:monospace,monospace">FCPR</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">FCPR naming convention is used to refer that it'a front camera.<br>In Atlas, is this a front or rear camera?<br>Please update all comments about front / rear as needed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@123">Patch Set #5, Line 123:</a> <code style="font-family:monospace,monospace">SSDB</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't believe SSDB is currently used. Please remove.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27350">change 27350</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27350"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d </div>
<div style="display:none"> Gerrit-Change-Number: 27350 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Ping-chung Chen <ping-chung.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Andy Yeh <andy.yeh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 09 Jul 2018 23:53:36 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>