[coreboot-gerrit] Change in coreboot[master]: google/asuka: Add as a variant of glados

Mon Jul 9 18:04:03 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27421 )

Change subject: google/asuka: Add as a variant of glados
......................................................................

Patch Set 2:

(22 comments)

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
File src/mainboard/google/glados/variants/asuka/include/variant/gpio.h:

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@81
PS2, Line 81: /* SD_PWR_EN */  	PAD_CFG_NC(GPP_A17),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@84
PS2, Line 84: /* GYRO_DRDY */ 	PAD_CFG_NC(GPP_A20),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@88
PS2, Line 88: /* CORE_VID0 */ 	PAD_CFG_NC(GPP_B0),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@89
PS2, Line 89: /* CORE_VID1 */ 	PAD_CFG_NC(GPP_B1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@93
PS2, Line 93: /* SRCCLKREQ0# */	PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */
line over 80 characters

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@100
PS2, Line 100: /* PM_SLP_S0 */  	PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@103
PS2, Line 103: /* GSPI0_CS# */ 	PAD_CFG_NC(GPP_B15),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@111
PS2, Line 111: /* SM1ALERT# */ 	PAD_CFG_NC(GPP_B23),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@114
PS2, Line 114: /* SMBALERT# */  	PAD_CFG_GPO(GPP_C2, 0, DEEP),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@145
PS2, Line 145: /* ISH_SPI_CSB */ 	PAD_CFG_NC(GPP_D9),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@162
PS2, Line 162: /* SSD_PEDET */ 	PAD_CFG_NC(GPP_E2),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@169
PS2, Line 169: /* USB2_OC_0 */  	PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@170
PS2, Line 170: /* USB2_OC_1 */  	PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@171
PS2, Line 171: /* USB2_OC_2 */  	PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@172
PS2, Line 172: /* USB2_OC_3 */  	PAD_CFG_NF(GPP_E12, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@185
PS2, Line 185: /* I2S2_SCLK */  	PAD_CFG_NC(GPP_F0),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@186
PS2, Line 186: /* I2S2_SFRM */  	PAD_CFG_NC(GPP_F1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@195
PS2, Line 195: /* AUDIO_IRQ */  	PAD_CFG_GPI_APIC(GPP_F10, NONE, PLTRST),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@196
PS2, Line 196: /* AUDIO_IRQ */  	PAD_CFG_GPI_ACPI_SCI(GPP_F11, NONE, DEEP, YES),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@225
PS2, Line 225: /* PM_SUSCLK */  	PAD_CFG_NF(GPD8, NONE, DEEP, NF1),
please, no space before tabs

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c
File src/mainboard/google/glados/variants/asuka/variant.c:

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c@27
PS2, Line 27: 		  { 0x0F, 0xF0, 0x00, 0xF0, 0x0F, 0xF0 ,
space prohibited before that ',' (ctx:WxE)

https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c@29
PS2, Line 29: 		  { 0x0F, 0xF0, 0x00, 0xF0, 0x0F, 0xF0 ,
space prohibited before that ',' (ctx:WxE)

-- 
To view, visit https://review.coreboot.org/27421
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I591578fea2514a28c75177835807c3f250904577
Gerrit-Change-Number: 27421
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/791a58d7/attachment.html>