<p><a href="https://review.coreboot.org/27421">View Change</a></p><p>22 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h">File src/mainboard/google/glados/variants/asuka/include/variant/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@81">Patch Set #2, Line 81:</a> <code style="font-family:monospace,monospace">/* SD_PWR_EN */ PAD_CFG_NC(GPP_A17),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@84">Patch Set #2, Line 84:</a> <code style="font-family:monospace,monospace">/* GYRO_DRDY */ PAD_CFG_NC(GPP_A20),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@88">Patch Set #2, Line 88:</a> <code style="font-family:monospace,monospace">/* CORE_VID0 */ PAD_CFG_NC(GPP_B0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@89">Patch Set #2, Line 89:</a> <code style="font-family:monospace,monospace">/* CORE_VID1 */ PAD_CFG_NC(GPP_B1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@93">Patch Set #2, Line 93:</a> <code style="font-family:monospace,monospace">/* SRCCLKREQ0# */ PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@100">Patch Set #2, Line 100:</a> <code style="font-family:monospace,monospace">/* PM_SLP_S0 */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@103">Patch Set #2, Line 103:</a> <code style="font-family:monospace,monospace">/* GSPI0_CS# */ PAD_CFG_NC(GPP_B15),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@111">Patch Set #2, Line 111:</a> <code style="font-family:monospace,monospace">/* SM1ALERT# */ PAD_CFG_NC(GPP_B23),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@114">Patch Set #2, Line 114:</a> <code style="font-family:monospace,monospace">/* SMBALERT# */ PAD_CFG_GPO(GPP_C2, 0, DEEP),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@145">Patch Set #2, Line 145:</a> <code style="font-family:monospace,monospace">/* ISH_SPI_CSB */ PAD_CFG_NC(GPP_D9),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@162">Patch Set #2, Line 162:</a> <code style="font-family:monospace,monospace">/* SSD_PEDET */ PAD_CFG_NC(GPP_E2),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@169">Patch Set #2, Line 169:</a> <code style="font-family:monospace,monospace">/* USB2_OC_0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@170">Patch Set #2, Line 170:</a> <code style="font-family:monospace,monospace">/* USB2_OC_1 */ PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@171">Patch Set #2, Line 171:</a> <code style="font-family:monospace,monospace">/* USB2_OC_2 */ PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@172">Patch Set #2, Line 172:</a> <code style="font-family:monospace,monospace">/* USB2_OC_3 */ PAD_CFG_NF(GPP_E12, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@185">Patch Set #2, Line 185:</a> <code style="font-family:monospace,monospace">/* I2S2_SCLK */ PAD_CFG_NC(GPP_F0),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@186">Patch Set #2, Line 186:</a> <code style="font-family:monospace,monospace">/* I2S2_SFRM */ PAD_CFG_NC(GPP_F1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@195">Patch Set #2, Line 195:</a> <code style="font-family:monospace,monospace">/* AUDIO_IRQ */ PAD_CFG_GPI_APIC(GPP_F10, NONE, PLTRST),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@196">Patch Set #2, Line 196:</a> <code style="font-family:monospace,monospace">/* AUDIO_IRQ */ PAD_CFG_GPI_ACPI_SCI(GPP_F11, NONE, DEEP, YES),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h@225">Patch Set #2, Line 225:</a> <code style="font-family:monospace,monospace">/* PM_SUSCLK */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c">File src/mainboard/google/glados/variants/asuka/variant.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c@27">Patch Set #2, Line 27:</a> <code style="font-family:monospace,monospace"> { 0x0F, 0xF0, 0x00, 0xF0, 0x0F, 0xF0 ,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxE)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27421/2/src/mainboard/google/glados/variants/asuka/variant.c@29">Patch Set #2, Line 29:</a> <code style="font-family:monospace,monospace"> { 0x0F, 0xF0, 0x00, 0xF0, 0x0F, 0xF0 ,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that ',' (ctx:WxE)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27421">change 27421</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27421"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I591578fea2514a28c75177835807c3f250904577 </div>
<div style="display:none"> Gerrit-Change-Number: 27421 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 09 Jul 2018 16:04:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>