[coreboot-gerrit] Change in coreboot[master]: google/caroline: Add as a variant of glados

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27419 )

Change subject: google/caroline: Add as a variant of glados
......................................................................


Patch Set 2:

(15 comments)

https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
File src/mainboard/google/glados/variants/caroline/include/variant/gpio.h:

https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@79
PS2, Line 79: /* PIRQA# */		PAD_CFG_GPI_GPIO_DRIVER(GPP_A7, 20K_PU, DEEP), /* SD_CD_INT_L */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@101
PS2, Line 101: /* SRCCLKREQ0# */	PAD_CFG_GPI_ACPI_SCI(GPP_B5, NONE, DEEP, YES), /* TOUCHPAD WAKE */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@111
PS2, Line 111: /* GSPI0_CS# */		PAD_CFG_GPI_ACPI_SCI(GPP_B15, NONE, DEEP, NONE), /* DIG EJECT */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@112
PS2, Line 112: /* GSPI0_CLK */		PAD_CFG_GPI_ACPI_SCI(GPP_B16, NONE, DEEP, YES), /* WLAN WAKE */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@115
PS2, Line 115: /* GSPI1_CS# */		PAD_CFG_GPI_GPIO_DRIVER(GPP_B19, NONE, DEEP), /* non-wake DIG EJECT */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@126
PS2, Line 126: /* SM1CLK */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C6, 20K_PU, DEEP), /* EC_IN_RW */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@132
PS2, Line 132: /* UART1_RXD */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP), /* MEM_CONFIG[0] */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@133
PS2, Line 133: /* UART1_TXD */		PAD_CFG_GPI_GPIO_DRIVER(GPP_C13, NONE, DEEP), /* MEM_CONFIG[1] */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@134
PS2, Line 134: /* UART1_RTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C14, NONE, DEEP), /* MEM_CONFIG[2] */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@135
PS2, Line 135: /* UART1_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C15, NONE, DEEP), /* MEM_CONFIG[3] */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@143
PS2, Line 143: /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@175
PS2, Line 175: /* CPU_GP1 */		PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST), /* TOUCHSCREEN */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@183
PS2, Line 183: /* DDPD_HPD2 */		PAD_CFG_GPI_ACPI_SMI(GPP_E15, NONE, DEEP, YES), /* EC_SMI_L */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@184
PS2, Line 184: /* DDPE_HPD3 */		PAD_CFG_GPI_ACPI_SCI(GPP_E16, NONE, DEEP, YES), /* EC_SCI_L */
line over 80 characters


https://review.coreboot.org/#/c/27419/2/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h@249
PS2, Line 249: /* UART2_CTS# */	PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP), /* PCH_WP */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I611a4e76581ba2e5b42e1bc48b0a5b8c70f3598e
Gerrit-Change-Number: 27419
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Jul 2018 16:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/47dff5d0/attachment.html>