[coreboot-gerrit] Change in coreboot[master]: google/caroline: Add as a variant of glados

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon Jul 9 18:02:52 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/27419

to look at the new patch set (#2).

Change subject: google/caroline: Add as a variant of glados
......................................................................

google/caroline: Add as a variant of glados

Add google/caroline (Samsung Chromebook Pro) as a variant of
glados Skylake reference board:
- add caroline-specific DPTF, EC config, GPIO config, Kconfig,
    NHLT config, PEI data, VBT, SPD data, and devicetree
- add caroline-specific memory-init param to romstage
- adjust mainboard EC SCI events for boards with tablet function

Adapted from Chromium branch firmware-glados-7820.B, commit
b0c3efe54d877246d07f2467b2dff51cc30348fa [soc/intel/skylake: Enable VMX]

Test: build/boot google/caroline, verify correct functionality

Change-Id: I611a4e76581ba2e5b42e1bc48b0a5b8c70f3598e
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/glados/Kconfig.name
M src/mainboard/google/glados/ec.h
M src/mainboard/google/glados/romstage.c
A src/mainboard/google/glados/spd/samsung_dimm_K4EBE304EB-EGCG.spd.hex
A src/mainboard/google/glados/variants/caroline/Makefile.inc
A src/mainboard/google/glados/variants/caroline/data.vbt
A src/mainboard/google/glados/variants/caroline/devicetree.cb
A src/mainboard/google/glados/variants/caroline/include/variant/acpi/dptf.asl
A src/mainboard/google/glados/variants/caroline/include/variant/acpi/mainboard.asl
A src/mainboard/google/glados/variants/caroline/include/variant/ec.h
A src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
A src/mainboard/google/glados/variants/caroline/variant.c
13 files changed, 913 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/27419/2
-- 
To view, visit https://review.coreboot.org/27419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I611a4e76581ba2e5b42e1bc48b0a5b8c70f3598e
Gerrit-Change-Number: 27419
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/0ab65237/attachment.html>


More information about the coreboot-gerrit mailing list