[coreboot-gerrit] Change in coreboot[master]: mediatek: Share GPIO code among similar SOCs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27416 )

Change subject: mediatek: Share GPIO code among similar SOCs
......................................................................


Patch Set 1:

(135 comments)

https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h
File src/soc/mediatek/mt8173/include/soc/pinmux.h:

https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@29
PS1, Line 29: 	PINMUX_CONSTANTS(GPIO_PAD_0, EINT0, IRDA_PDN, I2S1_WS, AUD_SPDIF, UTXD0, RES5, RES6, DBG_MON_A_20),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@30
PS1, Line 30: 	PINMUX_CONSTANTS(GPIO_PAD_1, EINT1, IRDA_RXD, I2S1_BCK, SDA5, URXD0, RES5, RES6, DBG_MON_A_21),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@31
PS1, Line 31: 	PINMUX_CONSTANTS(GPIO_PAD_2, EINT2, IRDA_TXD, I2S1_MCK, SCL5, UTXD3, RES5, RES6, DBG_MON_A_22),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@32
PS1, Line 32: 	PINMUX_CONSTANTS(GPIO_PAD_3, EINT3, DSI1_TE, I2S1_DO_1, SDA3, URXD3, RES5, RES6, DBG_MON_A_23),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@33
PS1, Line 33: 	PINMUX_CONSTANTS(GPIO_PAD_4, EINT4, DISP_PWM1, I2S1_DO_2, SCL3, UCTS3, RES5, SFWP_B, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@34
PS1, Line 34: 	PINMUX_CONSTANTS(GPIO_PAD_5, EINT5, PCM1_CLK, I2S2_WS, SPI_CK_3, URTS3, AP_MD32_JTAG_TMS, SFOUT, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@35
PS1, Line 35: 	PINMUX_CONSTANTS(GPIO_PAD_6, EINT6, PCM1_SYNC, I2S2_BCK, SPI_MI_3, RES4, AP_MD32_JTAG_TCK, SFCS0, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@36
PS1, Line 36: 	PINMUX_CONSTANTS(GPIO_PAD_7, EINT7, PCM1_DI, I2S2_DI_1, SPI_MO_3, RES4, AP_MD32_JTAG_TDI, SFHOLD, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@37
PS1, Line 37: 	PINMUX_CONSTANTS(GPIO_PAD_8, EINT8, PCM1_DO, I2S2_DI_2, SPI_CS_3, AUD_SPDIF, AP_MD32_JTAG_TDO, SFIN, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@38
PS1, Line 38: 	PINMUX_CONSTANTS(GPIO_PAD_9, EINT9, USB_DRVVBUS_P0, I2S2_MCK, RES3, USB_DRVVBUS_P1, AP_MD32_JTAG_TRST, SFCK, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@39
PS1, Line 39: 	PINMUX_CONSTANTS(GPIO_PAD_10, EINT10, CLKM0, DSI1_TE, DISP_PWM1, PWM4, IRDA_RXD, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@40
PS1, Line 40: 	PINMUX_CONSTANTS(GPIO_PAD_11, EINT11, CLKM1, I2S3_WS, USB_DRVVBUS_P0, PWM5, IRDA_TXD, USB_DRVVBUS_P1, DBG_MON_B_30),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@41
PS1, Line 41: 	PINMUX_CONSTANTS(GPIO_PAD_12, EINT12, CLKM2, I2S3_BCK, SRCLKENA0, RES4, I2S2_WS, RES6, DBG_MON_B_32),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@42
PS1, Line 42: 	PINMUX_CONSTANTS(GPIO_PAD_13, EINT13, CLKM3, I2S3_MCK, SRCLKENA0, RES4, I2S2_BCK, RES6, DBG_MON_A_32),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@43
PS1, Line 43: 	PINMUX_CONSTANTS(GPIO_PAD_14, EINT14, CMDAT0, CMCSD0, RES3, CLKM2, RES5, RES6, DBG_MON_B_6),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@44
PS1, Line 44: 	PINMUX_CONSTANTS(GPIO_PAD_15, EINT15, CMDAT1, CMCSD1, CMFLASH, CLKM3, RES5, RES6, DBG_MON_B_29),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@45
PS1, Line 45: 	PINMUX_CONSTANTS(GPIO_PAD_16, IDDIG, IDDIG, CMFLASH, RES3, PWM5, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@46
PS1, Line 46: 	PINMUX_CONSTANTS(GPIO_PAD_17, WATCHDOG, WATCHDOG_AO, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@47
PS1, Line 47: 	PINMUX_CONSTANTS(GPIO_PAD_18, CEC, CEC, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@48
PS1, Line 48: 	PINMUX_CONSTANTS(GPIO_PAD_19, HDMISCK, HDMISCK, HDCP_SCL, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@49
PS1, Line 49: 	PINMUX_CONSTANTS(GPIO_PAD_20, HDMISD, HDMISD, HDCP_SDA, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@50
PS1, Line 50: 	PINMUX_CONSTANTS(GPIO_PAD_21, HTPLG, HTPLG, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@51
PS1, Line 51: 	PINMUX_CONSTANTS(GPIO_PAD_22, MSDC3_DAT0, MSDC3_DAT0, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@52
PS1, Line 52: 	PINMUX_CONSTANTS(GPIO_PAD_23, MSDC3_DAT1, MSDC3_DAT1, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@53
PS1, Line 53: 	PINMUX_CONSTANTS(GPIO_PAD_24, MSDC3_DAT2, MSDC3_DAT2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@54
PS1, Line 54: 	PINMUX_CONSTANTS(GPIO_PAD_25, MSDC3_DAT3, MSDC3_DAT3, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@55
PS1, Line 55: 	PINMUX_CONSTANTS(GPIO_PAD_26, MSDC3_CLK, MSDC3_CLK, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@56
PS1, Line 56: 	PINMUX_CONSTANTS(GPIO_PAD_27, MSDC3_CMD, MSDC3_CMD, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@57
PS1, Line 57: 	PINMUX_CONSTANTS(GPIO_PAD_28, MSDC3_DSL, MSDC3_DSL, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@58
PS1, Line 58: 	PINMUX_CONSTANTS(GPIO_PAD_29, UCTS2, UCTS2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@59
PS1, Line 59: 	PINMUX_CONSTANTS(GPIO_PAD_30, URTS2, URTS2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@60
PS1, Line 60: 	PINMUX_CONSTANTS(GPIO_PAD_31, URXD2, URXD2, UTXD2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@61
PS1, Line 61: 	PINMUX_CONSTANTS(GPIO_PAD_32, UTXD2, UTXD2, URXD2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@62
PS1, Line 62: 	PINMUX_CONSTANTS(GPIO_PAD_33, DAICLK, MRG_CLK, PCM0_CLK, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@63
PS1, Line 63: 	PINMUX_CONSTANTS(GPIO_PAD_34, DAIPCMIN, MRG_DI, PCM0_DI, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@64
PS1, Line 64: 	PINMUX_CONSTANTS(GPIO_PAD_35, DAIPCMOUT, MRG_DO, PCM0_DO, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@65
PS1, Line 65: 	PINMUX_CONSTANTS(GPIO_PAD_36, DAISYNC, MRG_SYNC, PCM0_SYNC, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@66
PS1, Line 66: 	PINMUX_CONSTANTS(GPIO_PAD_37, EINT16, USB_DRVVBUS_P0, USB_DRVVBUS_P1, PWM0, PWM1, PWM2, CLKM0, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@67
PS1, Line 67: 	PINMUX_CONSTANTS(GPIO_PAD_38, CONN_RST, USB_DRVVBUS_P0, USB_DRVVBUS_P1, RES3, RES4, RES5, CLKM1, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@68
PS1, Line 68: 	PINMUX_CONSTANTS(GPIO_PAD_39, CM2MCLK, CM2MCLK, CMCSD0, RES3, RES4, RES5, RES6, DBG_MON_A_17),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@69
PS1, Line 69: 	PINMUX_CONSTANTS(GPIO_PAD_40, CMPCLK, CMPCLK, CMCSK, CMCSD2, RES4, RES5, RES6, DBG_MON_A_18),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@70
PS1, Line 70: 	PINMUX_CONSTANTS(GPIO_PAD_41, CMMCLK, CMMCLK, RES2, RES3, RES4, RES5, RES6, DBG_MON_A_19),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@71
PS1, Line 71: 	PINMUX_CONSTANTS(GPIO_PAD_42, DSI_TE, DSI_TE, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@72
PS1, Line 72: 	PINMUX_CONSTANTS(GPIO_PAD_43, SDA2, SDA2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@73
PS1, Line 73: 	PINMUX_CONSTANTS(GPIO_PAD_44, SCL2, SCL2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@74
PS1, Line 74: 	PINMUX_CONSTANTS(GPIO_PAD_45, SDA0, SDA0, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@75
PS1, Line 75: 	PINMUX_CONSTANTS(GPIO_PAD_46, SCL0, SCL0, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@76
PS1, Line 76: 	PINMUX_CONSTANTS(GPIO_PAD_47, RDN0_A, CMDAT2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@77
PS1, Line 77: 	PINMUX_CONSTANTS(GPIO_PAD_48, RDP0_A, CMDAT3, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@78
PS1, Line 78: 	PINMUX_CONSTANTS(GPIO_PAD_49, RDN1_A, CMDAT4, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@79
PS1, Line 79: 	PINMUX_CONSTANTS(GPIO_PAD_50, RDP1_A, CMDAT5, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@80
PS1, Line 80: 	PINMUX_CONSTANTS(GPIO_PAD_51, RCN_A, CMDAT6, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@81
PS1, Line 81: 	PINMUX_CONSTANTS(GPIO_PAD_52, RCP_A, CMDAT7, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@82
PS1, Line 82: 	PINMUX_CONSTANTS(GPIO_PAD_53, RDN2_A, CMDAT8, CMCSD3, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@83
PS1, Line 83: 	PINMUX_CONSTANTS(GPIO_PAD_54, RDP2_A, CMDAT9, CMCSD2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@84
PS1, Line 84: 	PINMUX_CONSTANTS(GPIO_PAD_55, RDN3_A, CMHSYNC, CMCSD1, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@85
PS1, Line 85: 	PINMUX_CONSTANTS(GPIO_PAD_56, RDP3_A, CMVSYNC, CMCSD0, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@86
PS1, Line 86: 	PINMUX_CONSTANTS(GPIO_PAD_57, MSDC0_DAT0, MSDC0_DAT0, I2S1_WS, RES3, RES4, RES5, RES6, DBG_MON_B_7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@87
PS1, Line 87: 	PINMUX_CONSTANTS(GPIO_PAD_58, MSDC0_DAT1, MSDC0_DAT1, I2S1_BCK, RES3, RES4, RES5, RES6, DBG_MON_B_8),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@88
PS1, Line 88: 	PINMUX_CONSTANTS(GPIO_PAD_59, MSDC0_DAT2, MSDC0_DAT2, I2S1_MCK, RES3, RES4, RES5, RES6, DBG_MON_B_9),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@89
PS1, Line 89: 	PINMUX_CONSTANTS(GPIO_PAD_60, MSDC0_DAT3, MSDC0_DAT3, I2S1_DO_1, RES3, RES4, RES5, RES6, DBG_MON_B_10),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@90
PS1, Line 90: 	PINMUX_CONSTANTS(GPIO_PAD_61, MSDC0_DAT4, MSDC0_DAT4, I2S1_DO_2, RES3, RES4, RES5, RES6, DBG_MON_B_11),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@91
PS1, Line 91: 	PINMUX_CONSTANTS(GPIO_PAD_62, MSDC0_DAT5, MSDC0_DAT5, I2S2_WS, RES3, RES4, RES5, RES6, DBG_MON_B_12),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@92
PS1, Line 92: 	PINMUX_CONSTANTS(GPIO_PAD_63, MSDC0_DAT6, MSDC0_DAT6, I2S2_BCK, RES3, RES4, RES5, RES6, DBG_MON_B_13),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@93
PS1, Line 93: 	PINMUX_CONSTANTS(GPIO_PAD_64, MSDC0_DAT7, MSDC0_DAT7, I2S2_DI_1, RES3, RES4, RES5, RES6, DBG_MON_B_14),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@94
PS1, Line 94: 	PINMUX_CONSTANTS(GPIO_PAD_65, MSDC0_CLK, MSDC0_CLK, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_16),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@95
PS1, Line 95: 	PINMUX_CONSTANTS(GPIO_PAD_66, MSDC0_CMD, MSDC0_CMD, I2S2_DI_2, RES3, RES4, RES5, RES6, DBG_MON_B_15),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@96
PS1, Line 96: 	PINMUX_CONSTANTS(GPIO_PAD_67, MSDC0_DSL, MSDC0_DSL, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_17),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@97
PS1, Line 97: 	PINMUX_CONSTANTS(GPIO_PAD_68, MSDC0_RST, MSDC0_RSTB, I2S2_MCK, RES3, RES4, RES5, RES6, DBG_MON_B_18),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@98
PS1, Line 98: 	PINMUX_CONSTANTS(GPIO_PAD_69, SPI_CK, SPI_CK_0, I2S3_DO_1, PWM0, PWM5, I2S2_MCK, RES6, DBG_MON_B_19),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@99
PS1, Line 99: 	PINMUX_CONSTANTS(GPIO_PAD_70, SPI_MI, SPI_MI_0, I2S3_DO_2, PWM1, SPI_MO_0, I2S2_DI_1, DSI1_TE, DBG_MON_B_20),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@100
PS1, Line 100: 	PINMUX_CONSTANTS(GPIO_PAD_71, SPI_MO, SPI_MO_0, I2S3_DO_3, PWM2, SPI_MI_0, I2S2_DI_2, RES6, DBG_MON_B_21),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@101
PS1, Line 101: 	PINMUX_CONSTANTS(GPIO_PAD_72, SPI_CS, SPI_CS_0, I2S3_DO_4, PWM3, PWM6, DISP_PWM1, RES6, DBG_MON_B_22),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@102
PS1, Line 102: 	PINMUX_CONSTANTS(GPIO_PAD_73, MSDC1_DAT0, MSDC1_DAT0, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_24),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@103
PS1, Line 103: 	PINMUX_CONSTANTS(GPIO_PAD_74, MSDC1_DAT1, MSDC1_DAT1, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_25),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@104
PS1, Line 104: 	PINMUX_CONSTANTS(GPIO_PAD_75, MSDC1_DAT2, MSDC1_DAT2, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_26),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@105
PS1, Line 105: 	PINMUX_CONSTANTS(GPIO_PAD_76, MSDC1_DAT3, MSDC1_DAT3, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_27),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@106
PS1, Line 106: 	PINMUX_CONSTANTS(GPIO_PAD_77, MSDC1_CLK, MSDC1_CLK, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_28),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@107
PS1, Line 107: 	PINMUX_CONSTANTS(GPIO_PAD_78, MSDC1_CMD, MSDC1_CMD, RES2, RES3, RES4, RES5, RES6, DBG_MON_B_23),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@108
PS1, Line 108: 	PINMUX_CONSTANTS(GPIO_PAD_79, PWRAP_SPI0_MI, PWRAP_SPIMI, PWRAP_SPIMO, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@109
PS1, Line 109: 	PINMUX_CONSTANTS(GPIO_PAD_80, PWRAP_SPI0_MO, PWRAP_SPIMO, PWRAP_SPIMI, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@110
PS1, Line 110: 	PINMUX_CONSTANTS(GPIO_PAD_81, PWRAP_SPI0_CK, PWRAP_SPICK, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@111
PS1, Line 111: 	PINMUX_CONSTANTS(GPIO_PAD_82, PWRAP_SPI0_CSN, PWRAP_SPICS, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@112
PS1, Line 112: 	PINMUX_CONSTANTS(GPIO_PAD_83, AUD_CLK_MOSI, AUD_CLK_MOSI, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@113
PS1, Line 113: 	PINMUX_CONSTANTS(GPIO_PAD_84, AUD_DAT_MISO, AUD_DAT_MISO, AUD_DAT_MOSI, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@114
PS1, Line 114: 	PINMUX_CONSTANTS(GPIO_PAD_85, AUD_DAT_MOSI, AUD_DAT_MOSI, AUD_DAT_MISO, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@115
PS1, Line 115: 	PINMUX_CONSTANTS(GPIO_PAD_86, RTC32K_CK, RTC32K_CK, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@116
PS1, Line 116: 	PINMUX_CONSTANTS(GPIO_PAD_87, DISP_PWM0, DISP_PWM0, DISP_PWM1, RES3, RES4, RES5, RES6, DBG_MON_B_31),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@117
PS1, Line 117: 	PINMUX_CONSTANTS(GPIO_PAD_88, SRCLKENAI, SRCLKENAI, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@118
PS1, Line 118: 	PINMUX_CONSTANTS(GPIO_PAD_89, SRCLKENAI2, SRCLKENAI2, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@119
PS1, Line 119: 	PINMUX_CONSTANTS(GPIO_PAD_90, SRCLKENA0, SRCLKENA0, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@120
PS1, Line 120: 	PINMUX_CONSTANTS(GPIO_PAD_91, SRCLKENA1, SRCLKENA1, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@121
PS1, Line 121: 	PINMUX_CONSTANTS(GPIO_PAD_92, PCM_CLK, PCM1_CLK, I2S0_BCK, RES3, RES4, RES5, RES6, DBG_MON_A_24),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@122
PS1, Line 122: 	PINMUX_CONSTANTS(GPIO_PAD_93, PCM_SYNC, PCM1_SYNC, I2S0_WS, RES3, RES4, RES5, RES6, DBG_MON_A_25),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@123
PS1, Line 123: 	PINMUX_CONSTANTS(GPIO_PAD_94, PCM_RX, PCM1_DI, I2S0_DI, RES3, RES4, RES5, RES6, DBG_MON_A_26),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@124
PS1, Line 124: 	PINMUX_CONSTANTS(GPIO_PAD_95, PCM_TX, PCM1_DO, I2S0_DO, RES3, RES4, RES5, RES6, DBG_MON_A_27),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@125
PS1, Line 125: 	PINMUX_CONSTANTS(GPIO_PAD_96, URXD1, URXD1, UTXD1, RES3, RES4, RES5, RES6, DBG_MON_A_28),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@126
PS1, Line 126: 	PINMUX_CONSTANTS(GPIO_PAD_97, UTXD1, UTXD1, URXD1, RES3, RES4, RES5, RES6, DBG_MON_A_29),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@127
PS1, Line 127: 	PINMUX_CONSTANTS(GPIO_PAD_98, URTS1, URTS1, UCTS1, RES3, RES4, RES5, RES6, DBG_MON_A_30),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@128
PS1, Line 128: 	PINMUX_CONSTANTS(GPIO_PAD_99, UCTS1, UCTS1, URTS1, RES3, RES4, RES5, RES6, DBG_MON_A_31),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@129
PS1, Line 129: 	PINMUX_CONSTANTS(GPIO_PAD_100, MSDC2_DAT0, MSDC2_DAT0, RES2, USB_DRVVBUS_P0, SDA5, USB_DRVVBUS_P1, RES6, DBG_MON_B_0),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@130
PS1, Line 130: 	PINMUX_CONSTANTS(GPIO_PAD_101, MSDC2_DAT1, MSDC2_DAT1, RES2, AUD_SPDIF, SCL5, RES5, RES6, DBG_MON_B_1),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@131
PS1, Line 131: 	PINMUX_CONSTANTS(GPIO_PAD_102, MSDC2_DAT2, MSDC2_DAT2, RES2, UTXD0, RES4, PWM0, SPI_CK_1, DBG_MON_B_2),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@132
PS1, Line 132: 	PINMUX_CONSTANTS(GPIO_PAD_103, MSDC2_DAT3, MSDC2_DAT3, RES2, URXD0, RES4, PWM1, SPI_MI_1, DBG_MON_B_3),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@133
PS1, Line 133: 	PINMUX_CONSTANTS(GPIO_PAD_104, MSDC2_CLK, MSDC2_CLK, RES2, UTXD3, SDA3, PWM2, SPI_MO_1, DBG_MON_B_4),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@134
PS1, Line 134: 	PINMUX_CONSTANTS(GPIO_PAD_105, MSDC2_CMD, MSDC2_CMD, RES2, URXD3, SCL3, PWM3, SPI_CS_1, DBG_MON_B_5),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@135
PS1, Line 135: 	PINMUX_CONSTANTS(GPIO_PAD_106, SDA3, SDA3, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@136
PS1, Line 136: 	PINMUX_CONSTANTS(GPIO_PAD_107, SCL3, SCL3, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@137
PS1, Line 137: 	PINMUX_CONSTANTS(GPIO_PAD_108, JTMS, JTMS, MFG_JTAG_TMS, RES3, RES4, AP_MD32_JTAG_TMS, DFD_TMS, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@138
PS1, Line 138: 	PINMUX_CONSTANTS(GPIO_PAD_109, JTCK, JTCK, MFG_JTAG_TCK, RES3, RES4, AP_MD32_JTAG_TCK, DFD_TCK, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@139
PS1, Line 139: 	PINMUX_CONSTANTS(GPIO_PAD_110, JTDI, JTDI, MFG_JTAG_TDI, RES3, RES4, AP_MD32_JTAG_TDI, DFD_TDI, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@140
PS1, Line 140: 	PINMUX_CONSTANTS(GPIO_PAD_111, JTDO, JTDO, MFG_JTAG_TDO, RES3, RES4, AP_MD32_JTAG_TDO, DFD_TDO, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@141
PS1, Line 141: 	PINMUX_CONSTANTS(GPIO_PAD_112, JTRST_B, JTRST_B, MFG_JTAG_TRSTN, RES3, RES4, AP_MD32_JTAG_TRST, DFD_NTRST, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@142
PS1, Line 142: 	PINMUX_CONSTANTS(GPIO_PAD_113, URXD0, URXD0, UTXD0, RES3, RES4, RES5, I2S2_WS, DBG_MON_A_0),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@143
PS1, Line 143: 	PINMUX_CONSTANTS(GPIO_PAD_114, UTXD0, UTXD0, URXD0, RES3, RES4, RES5, I2S2_BCK, DBG_MON_A_1),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@144
PS1, Line 144: 	PINMUX_CONSTANTS(GPIO_PAD_115, URTS0, URTS0, UCTS0, RES3, RES4, RES5, I2S2_MCK, DBG_MON_A_2),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@145
PS1, Line 145: 	PINMUX_CONSTANTS(GPIO_PAD_116, UCTS0, UCTS0, URTS0, RES3, RES4, RES5, I2S2_DI_1, DBG_MON_A_3),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@146
PS1, Line 146: 	PINMUX_CONSTANTS(GPIO_PAD_117, URXD3, URXD3, UTXD3, RES3, RES4, RES5, RES6, DBG_MON_A_9),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@147
PS1, Line 147: 	PINMUX_CONSTANTS(GPIO_PAD_118, UTXD3, UTXD3, URXD3, RES3, RES4, RES5, RES6, DBG_MON_A_10),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@148
PS1, Line 148: 	PINMUX_CONSTANTS(GPIO_PAD_119, KPROW0, KROW0, RES2, RES3, RES4, RES5, RES6, DBG_MON_A_11),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@149
PS1, Line 149: 	PINMUX_CONSTANTS(GPIO_PAD_120, KPROW1, KROW1, RES2, PWM6, RES4, RES5, RES6, DBG_MON_A_12),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@150
PS1, Line 150: 	PINMUX_CONSTANTS(GPIO_PAD_121, KPROW2, KROW2, IRDA_PDN, USB_DRVVBUS_P0, PWM4, USB_DRVVBUS_P1, RES6, DBG_MON_A_13),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@151
PS1, Line 151: 	PINMUX_CONSTANTS(GPIO_PAD_122, KPCOL0, KCOL0, RES2, RES3, RES4, RES5, RES6, DBG_MON_A_14),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@152
PS1, Line 152: 	PINMUX_CONSTANTS(GPIO_PAD_123, KPCOL1, KCOL1, IRDA_RXD, PWM5, RES4, RES5, RES6, DBG_MON_A_15),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@153
PS1, Line 153: 	PINMUX_CONSTANTS(GPIO_PAD_124, KPCOL2, KCOL2, IRDA_TXD, USB_DRVVBUS_P0, PWM3, USB_DRVVBUS_P1, RES6, DBG_MON_A_16),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@154
PS1, Line 154: 	PINMUX_CONSTANTS(GPIO_PAD_125, SDA1, SDA1, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@155
PS1, Line 155: 	PINMUX_CONSTANTS(GPIO_PAD_126, SCL1, SCL1, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@156
PS1, Line 156: 	PINMUX_CONSTANTS(GPIO_PAD_127, LCM_RST, LCM_RST, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@157
PS1, Line 157: 	PINMUX_CONSTANTS(GPIO_PAD_128, I2S0_LRCK, I2S0_WS, I2S1_WS, I2S2_WS, RES4, SPI_CK_2, RES6, DBG_MON_A_4),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@158
PS1, Line 158: 	PINMUX_CONSTANTS(GPIO_PAD_129, I2S0_BCK, I2S0_BCK, I2S1_BCK, I2S2_BCK, RES4, SPI_MI_2, RES6, DBG_MON_A_5),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@159
PS1, Line 159: 	PINMUX_CONSTANTS(GPIO_PAD_130, I2S0_MCK, I2S0_MCK, I2S1_MCK, I2S2_MCK, RES4, SPI_MO_2, RES6, DBG_MON_A_6),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@160
PS1, Line 160: 	PINMUX_CONSTANTS(GPIO_PAD_131, I2S0_DATA0, I2S0_DO, I2S1_DO_1, I2S2_DI_1, RES4, SPI_CS_2, RES6, DBG_MON_A_7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@161
PS1, Line 161: 	PINMUX_CONSTANTS(GPIO_PAD_132, I2S0_DATA1, I2S0_DI, I2S1_DO_2, I2S2_DI_2, RES4, RES5, RES6, DBG_MON_A_8),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@162
PS1, Line 162: 	PINMUX_CONSTANTS(GPIO_PAD_133, SDA4, SDA4, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters


https://review.coreboot.org/#/c/27416/1/src/soc/mediatek/mt8173/include/soc/pinmux.h@163
PS1, Line 163: 	PINMUX_CONSTANTS(GPIO_PAD_134, SCL4, SCL4, RES2, RES3, RES4, RES5, RES6, RES7),
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0
Gerrit-Change-Number: 27416
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Jul 2018 11:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/678fe09f/attachment.html>