[coreboot-gerrit] Change in coreboot[master]: google/glados: Convert to variant setup

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon Jul 9 09:54:52 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/27411

to look at the new patch set (#2).

Change subject: google/glados: Convert to variant setup
......................................................................

google/glados: Convert to variant setup

Convert Skylake reference board glados to variant setup in
preparation for merge with existing Skylake boards chell and lars,
and upstreaming of new boards asuka, caroline, cave, and sentry.

The following changes have been made:
- move DPTF to variant subdir
- move non-common EC defs to variant subdir
- adjust Kconfig for variant setup
- move non-common NHLT config to variant Kconfig
- make non-common NHLT ACPI code conditional
- move devicetree to variant subdir
- move board GPIO defs to variant subdir
- move board PEI data to variant subdir
- move SPD index calculation to romstage so available for
    dual-channel determination during PEI for boards which need it
- move SPD compilation to variant makefile
- add weak function for determination of dual-channel RAM
- add weak function for mainboard_gpio_smi_sleep() so SKL-Y variants
    can override and power down rails as needed

Test: build google/glados

Change-Id: I41615979dc11b5a10e32d6b5f477a256735cde53
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/glados/Kconfig.name
M src/mainboard/google/glados/Makefile.inc
M src/mainboard/google/glados/acpi/dptf.asl
M src/mainboard/google/glados/acpi/ec.asl
M src/mainboard/google/glados/acpi/mainboard.asl
M src/mainboard/google/glados/acpi/superio.asl
M src/mainboard/google/glados/bootblock_mainboard.c
M src/mainboard/google/glados/chromeos.c
M src/mainboard/google/glados/mainboard.c
M src/mainboard/google/glados/ramstage.c
M src/mainboard/google/glados/romstage.c
M src/mainboard/google/glados/smihandler.c
M src/mainboard/google/glados/spd/spd.c
A src/mainboard/google/glados/variants/baseboard/include/baseboard/variant.h
R src/mainboard/google/glados/variants/glados/Makefile.inc
R src/mainboard/google/glados/variants/glados/devicetree.cb
A src/mainboard/google/glados/variants/glados/include/variant/acpi/dptf.asl
A src/mainboard/google/glados/variants/glados/include/variant/acpi/mainboard.asl
A src/mainboard/google/glados/variants/glados/include/variant/ec.h
R src/mainboard/google/glados/variants/glados/include/variant/gpio.h
R src/mainboard/google/glados/variants/glados/variant.c
22 files changed, 222 insertions(+), 133 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/27411/2
-- 
To view, visit https://review.coreboot.org/27411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41615979dc11b5a10e32d6b5f477a256735cde53
Gerrit-Change-Number: 27411
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180709/3a3d92ec/attachment.html>


More information about the coreboot-gerrit mailing list