[coreboot-gerrit] Change in coreboot[master]: src/northbridge: Use "foo *bar" instead of "foo* bar"

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Jul 8 12:42:56 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27407 )

Change subject: src/northbridge: Use "foo *bar" instead of "foo* bar"
......................................................................


Patch Set 1:

(33 comments)

https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h
File src/northbridge/amd/amdmct/mct_ddr3/mct_d.h:

https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1058
PS1, Line 1058: void read_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1059
PS1, Line 1059: void read_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1136
PS1, Line 1136: void write_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c
File src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c:

https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c@320
PS1, Line 320: static void read_dqs_write_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c@349
PS1, Line 349: static void write_dqs_write_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
File src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c:

https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@258
PS1, Line 258: void read_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@285
PS1, Line 285: static void write_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@317
PS1, Line 317: static void write_write_data_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@356
PS1, Line 356: void read_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@390
PS1, Line 390: void write_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@427
PS1, Line 427: static void read_dram_phase_recovery_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@459
PS1, Line 459: static void write_dram_phase_recovery_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@497
PS1, Line 497: void read_dqs_read_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@531
PS1, Line 531: void write_dqs_read_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:

https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@272
PS1, Line 272: static void copy_cbmem_spd_data_to_save_variable(struct amd_s3_persistent_data *persistent_data, uint8_t *restored)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@306
PS1, Line 306: void copy_mct_data_to_save_variable(struct amd_s3_persistent_data *persistent_data)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@329
PS1, Line 329: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@597
PS1, Line 597: void restore_mct_data_from_save_variable(struct amd_s3_persistent_data *persistent_data, uint8_t training_only)
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@611
PS1, Line 611: 				struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@655
PS1, Line 655: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@666
PS1, Line 666: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@722
PS1, Line 722: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@761
PS1, Line 761: 				struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@826
PS1, Line 826: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@871
PS1, Line 871: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@912
PS1, Line 912: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@929
PS1, Line 929: 				struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@967
PS1, Line 967: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@986
PS1, Line 986: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1013
PS1, Line 1013: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1037
PS1, Line 1037: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1069
PS1, Line 1069: 				struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters


https://review.coreboot.org/#/c/27407/1/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1084
PS1, Line 1084: 			struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27407
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf86a0c91da089b486bd39518e5c8216163bf8ec
Gerrit-Change-Number: 27407
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 08 Jul 2018 10:42:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180708/8ebb1ed4/attachment.html>


More information about the coreboot-gerrit mailing list