[coreboot-gerrit] Change in coreboot[master]: riscv: add trampoline in MBR block to support boot mode 1

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/27397 )

Change subject: riscv: add trampoline in MBR block to support boot mode 1
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/27397/3//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27397/3//COMMIT_MSG@11
PS3, Line 11: issues.
> Stack alignment? How is that influenced? […]
The trampoline part contains the location of the bootblock, so if the change is split, the jump would need to change as well.


The reason for this is, that the same code can be run directly and also when copied by the ZSBL.

And the linker complains when putting the stack at a non 0x1000-aligned address.
/home/user/dev/coreboot/util/crossgcc/xgcc/bin/riscv64-elf-ld.bfd: stack must be aligned to 4096!



-- 
To view, visit https://review.coreboot.org/27397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16e762d9f027346b124412f1f7ee6ff37f431d86
Gerrit-Change-Number: 27397
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 07 Jul 2018 12:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180707/afbe3564/attachment.html>