[coreboot-gerrit] Change in coreboot[master]: riscv: add trampoline in MBR block to support boot mode 1
Jonathan Neuschäfer (Code Review)
gerrit at coreboot.org
Sat Jul 7 13:44:42 CEST 2018
Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/27397 )
Change subject: riscv: add trampoline in MBR block to support boot mode 1
......................................................................
Patch Set 3:
(1 comment)
Thanks!
https://review.coreboot.org/#/c/27397/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/27397/3//COMMIT_MSG@11
PS3, Line 11: issues.
Stack alignment? How is that influenced?
I'd prefer if you split this part out, into a second patch, because it's less obvious.
--
To view, visit https://review.coreboot.org/27397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16e762d9f027346b124412f1f7ee6ff37f431d86
Gerrit-Change-Number: 27397
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 07 Jul 2018 11:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180707/e4013c6d/attachment.html>
More information about the coreboot-gerrit
mailing list