[coreboot-gerrit] Change in coreboot[master]: [Atlas] MIPI camera ASL files for Atlas

[Andy Yeh (Code Review)]

Andy Yeh has posted comments on this change. ( https://review.coreboot.org/27350 )

Change subject: [Atlas] MIPI camera ASL files for Atlas
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

please also change comment per the original patch.
https://review.coreboot.org/#/c/coreboot/+/25536/

and please open a ticket to track this CL.

https://partnerissuetracker.corp.google.com/

https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:

https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@115
PS1, Line 115: Package() { 384000000, 96000000 }
should be slower for imx208 as the current settings are for nautilus/nocturne.


https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@122
PS1, Line 122: 		
remove the blanks


https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h
File src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h:

https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h@27
PS1, Line 27: #define EN_CAM_CLOCK	GPP_D18
suggest to add one more tab to align in gerrit review.



-- 
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 1
Gerrit-Owner: Ping-chung Chen <ping-chung.chen at intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh at intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang at intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Comment-Date: Wed, 04 Jul 2018 07:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180704/6adec336/attachment.html>