<p style="white-space: pre-wrap; word-wrap: break-word;">please also change comment per the original patch.<br>https://review.coreboot.org/#/c/coreboot/+/25536/</p><p style="white-space: pre-wrap; word-wrap: break-word;">and please open a ticket to track this CL.</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://partnerissuetracker.corp.google.com/</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://review.coreboot.org/27350">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl">File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@115">Patch Set #1, Line 115:</a> <code style="font-family:monospace,monospace">Package() { 384000000, 96000000 }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should be slower for imx208 as the current settings are for nautilus/nocturne.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl@122">Patch Set #1, Line 122:</a> <code style="font-family:monospace,monospace">           </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove the blanks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h">File src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27350/1/src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace">#define EN_CAM_CLOCK     GPP_D18</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suggest to add one more tab to align in gerrit review.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27350">change 27350</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27350"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d </div>
<div style="display:none"> Gerrit-Change-Number: 27350 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Ping-chung Chen <ping-chung.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Andy Yeh <andy.yeh@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 04 Jul 2018 07:30:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>