[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: correct GPIO emission error in ACPI

[Kevin Chiu (Code Review)]

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/27306


Change subject: soc/amd/stoneyridge: correct GPIO emission error in ACPI
......................................................................

soc/amd/stoneyridge: correct GPIO emission error in ACPI

It can not emit byte data without BytePrefix.

BUG=b:110962003
BRANCH=master
TEST=emerge-grunt coreboot
     extract SSDT then check ACPI syntax is correct
Change-Id: I7a0704112b77105826de87b14a38ed2f665224d5
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/soc/amd/stoneyridge/acpi.c
1 file changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/27306/1

diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index 8130b79..5f9e792 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -357,14 +357,19 @@
 	}
 	uintptr_t addr = (uintptr_t) gpio_get_address(gpio_num);
 
+	/* Store (0x40, Local0) */
+	acpigen_write_store();
+	acpigen_write_integer(GPIO_PIN_OUT);
+	acpigen_emit_byte(LOCAL0_OP);
+
 	acpigen_soc_get_gpio_in_local5(addr);
 
 	if (val) {
 		/* Or (Local5, GPIO_PIN_OUT, Local5) */
-		acpigen_write_or(LOCAL5_OP, GPIO_PIN_OUT, LOCAL5_OP);
+		acpigen_write_or(LOCAL5_OP, LOCAL0_OP, LOCAL5_OP);
 	} else {
 		/* Not (GPIO_PIN_OUT, Local6) */
-		acpigen_write_not(GPIO_PIN_OUT, LOCAL6_OP);
+		acpigen_write_not(LOCAL0_OP, LOCAL6_OP);
 
 		/* And (Local5, Local6, Local5) */
 		acpigen_write_and(LOCAL5_OP, LOCAL6_OP, LOCAL5_OP);

-- 
To view, visit https://review.coreboot.org/27306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a0704112b77105826de87b14a38ed2f665224d5
Gerrit-Change-Number: 27306
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180702/6d73a601/attachment.html>