<p>Kevin Chiu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27306">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge: correct GPIO emission error in ACPI<br><br>It can not emit byte data without BytePrefix.<br><br>BUG=b:110962003<br>BRANCH=master<br>TEST=emerge-grunt coreboot<br>     extract SSDT then check ACPI syntax is correct<br>Change-Id: I7a0704112b77105826de87b14a38ed2f665224d5<br>Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com><br>---<br>M src/soc/amd/stoneyridge/acpi.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/27306/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c</span><br><span>index 8130b79..5f9e792 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi.c</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi.c</span><br><span>@@ -357,14 +357,19 @@</span><br><span>        }</span><br><span>    uintptr_t addr = (uintptr_t) gpio_get_address(gpio_num);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  /* Store (0x40, Local0) */</span><br><span style="color: hsl(120, 100%, 40%);">+    acpigen_write_store();</span><br><span style="color: hsl(120, 100%, 40%);">+        acpigen_write_integer(GPIO_PIN_OUT);</span><br><span style="color: hsl(120, 100%, 40%);">+  acpigen_emit_byte(LOCAL0_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      acpigen_soc_get_gpio_in_local5(addr);</span><br><span> </span><br><span>    if (val) {</span><br><span>           /* Or (Local5, GPIO_PIN_OUT, Local5) */</span><br><span style="color: hsl(0, 100%, 40%);">-         acpigen_write_or(LOCAL5_OP, GPIO_PIN_OUT, LOCAL5_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+         acpigen_write_or(LOCAL5_OP, LOCAL0_OP, LOCAL5_OP);</span><br><span>   } else {</span><br><span>             /* Not (GPIO_PIN_OUT, Local6) */</span><br><span style="color: hsl(0, 100%, 40%);">-                acpigen_write_not(GPIO_PIN_OUT, LOCAL6_OP);</span><br><span style="color: hsl(120, 100%, 40%);">+           acpigen_write_not(LOCAL0_OP, LOCAL6_OP);</span><br><span> </span><br><span>                 /* And (Local5, Local6, Local5) */</span><br><span>           acpigen_write_and(LOCAL5_OP, LOCAL6_OP, LOCAL5_OP);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27306">change 27306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27306"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7a0704112b77105826de87b14a38ed2f665224d5 </div>
<div style="display:none"> Gerrit-Change-Number: 27306 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com> </div>