[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu1: use generic SPD

[Piotr Król (Code Review)]

Hello Michał Żygowski,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/27301

to review the following change.


Change subject: mb/pcengines/apu1: use generic SPD
......................................................................

mb/pcengines/apu1: use generic SPD

Clean up leftovers of old SPD generation and utilize
common procedure to produce SPD binary.

Change-Id: I4e48817c03b4372887bc0ea14209736ae2b4e48f
Signed-off-by: Michał Żygowski <michal.zygowski at 3mdeb.com>
---
M src/mainboard/pcengines/apu1/Kconfig
M src/mainboard/pcengines/apu1/Makefile.inc
R src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
R src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex
4 files changed, 3 insertions(+), 17 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/27301/1

diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig
index 5e927cc..19a5de4 100644
--- a/src/mainboard/pcengines/apu1/Kconfig
+++ b/src/mainboard/pcengines/apu1/Kconfig
@@ -29,6 +29,7 @@
 	select HAVE_OPTION_TABLE
 	select HAVE_CMOS_DEFAULT
 	select BOARD_ROMSIZE_KB_2048
+	select GENERIC_SPD_BIN
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/pcengines/apu1/Makefile.inc b/src/mainboard/pcengines/apu1/Makefile.inc
index 324e4aa..543ac97 100644
--- a/src/mainboard/pcengines/apu1/Makefile.inc
+++ b/src/mainboard/pcengines/apu1/Makefile.inc
@@ -31,22 +31,7 @@
 ramstage-y += OemCustomize.c
 ramstage-y += gpio_ftns.c
 
-## DIMM SPD for on-board memory
-SPD_BIN = $(obj)/spd.bin
 
 # Order of names in SPD_SOURCES is important!
-SPD_SOURCES  = HYNIX-H5TQ2G83CFR HYNIX-H5TQ4G83MFR
-
-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex)
-
-# Include spd ROM data
-$(SPD_BIN): $(SPD_DEPS)
-	for f in $+; \
-	  do for c in $$(cat $$f | grep -v ^#); \
-	    do printf $$(printf '\%o' 0x$$c); \
-	  done; \
-	done > $@
-
-cbfs-files-y += spd.bin
-spd.bin-file := $(SPD_BIN)
-spd.bin-type := spd
+SPD_SOURCES = HYNIX-H5TQ2G83CFR
+SPD_SOURCES += HYNIX-H5TQ4G83MFR
diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
similarity index 100%
rename from src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex
rename to src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex
diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex
similarity index 100%
rename from src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex
rename to src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex

-- 
To view, visit https://review.coreboot.org/27301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e48817c03b4372887bc0ea14209736ae2b4e48f
Gerrit-Change-Number: 27301
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180702/ed3aa103/attachment.html>