<p>Piotr Król would like Michał Żygowski to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/27301">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/pcengines/apu1: use generic SPD<br><br>Clean up leftovers of old SPD generation and utilize<br>common procedure to produce SPD binary.<br><br>Change-Id: I4e48817c03b4372887bc0ea14209736ae2b4e48f<br>Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com><br>---<br>M src/mainboard/pcengines/apu1/Kconfig<br>M src/mainboard/pcengines/apu1/Makefile.inc<br>R src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex<br>R src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex<br>4 files changed, 3 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/27301/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig</span><br><span>index 5e927cc..19a5de4 100644</span><br><span>--- a/src/mainboard/pcengines/apu1/Kconfig</span><br><span>+++ b/src/mainboard/pcengines/apu1/Kconfig</span><br><span>@@ -29,6 +29,7 @@</span><br><span>         select HAVE_OPTION_TABLE</span><br><span>     select HAVE_CMOS_DEFAULT</span><br><span>     select BOARD_ROMSIZE_KB_2048</span><br><span style="color: hsl(120, 100%, 40%);">+  select GENERIC_SPD_BIN</span><br><span> </span><br><span> config MAINBOARD_DIR</span><br><span>   string</span><br><span>diff --git a/src/mainboard/pcengines/apu1/Makefile.inc b/src/mainboard/pcengines/apu1/Makefile.inc</span><br><span>index 324e4aa..543ac97 100644</span><br><span>--- a/src/mainboard/pcengines/apu1/Makefile.inc</span><br><span>+++ b/src/mainboard/pcengines/apu1/Makefile.inc</span><br><span>@@ -31,22 +31,7 @@</span><br><span> ramstage-y += OemCustomize.c</span><br><span> ramstage-y += gpio_ftns.c</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-## DIMM SPD for on-board memory</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_BIN = $(obj)/spd.bin</span><br><span> </span><br><span> # Order of names in SPD_SOURCES is important!</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES  = HYNIX-H5TQ2G83CFR HYNIX-H5TQ4G83MFR</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-# Include spd ROM data</span><br><span style="color: hsl(0, 100%, 40%);">-$(SPD_BIN): $(SPD_DEPS)</span><br><span style="color: hsl(0, 100%, 40%);">-    for f in $+; \</span><br><span style="color: hsl(0, 100%, 40%);">-    do for c in $$(cat $$f | grep -v ^#); \</span><br><span style="color: hsl(0, 100%, 40%);">-           do printf $$(printf '\%o' 0x$$c); \</span><br><span style="color: hsl(0, 100%, 40%);">-   done; \</span><br><span style="color: hsl(0, 100%, 40%);">-       done > $@</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-cbfs-files-y += spd.bin</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-file := $(SPD_BIN)</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-type := spd</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES = HYNIX-H5TQ2G83CFR</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += HYNIX-H5TQ4G83MFR</span><br><span>diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/pcengines/apu1/HYNIX-H5TQ2G83CFR.spd.hex</span><br><span>rename to src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ2G83CFR.spd.hex</span><br><span>diff --git a/src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex b/src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/pcengines/apu1/HYNIX-H5TQ4G83MFR.spd.hex</span><br><span>rename to src/mainboard/pcengines/apu1/spd/HYNIX-H5TQ4G83MFR.spd.hex</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27301">change 27301</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27301"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4e48817c03b4372887bc0ea14209736ae2b4e48f </div>
<div style="display:none"> Gerrit-Change-Number: 27301 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Piotr Król <piotr.krol@3mdeb.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> </div>