[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23490


Change subject: nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS
......................................................................

nb/intel/sandybridge: Always use the same MMCONF_BASE_ADDRESS

'Optimizing' MMCONF_BASE_ADDRESS for the native codepath prevents the
use of fallback/normal with both the native raminit and the mrc.bin.

This means that 128MB less is available to devices using the native
raminit. Most devices reserve 2048M for non memory resources below 4G,
which in most cases is more than adequate. Devices with only 1024M (and
that don't use the mrc.bin) are:
* lenovo/x220
* lenovo/x230
* lenovo/x131e
* lenovo/x1_carbon_gen1

Those could fail to allocate PCI resources, but on at least x220 with
a somewhat default configuration (USB3 expresscard, Wireless PCIe
card) still boots fine, so one should not expect much problem from
this change.

Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/sandybridge/Kconfig
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23490/1

diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig
index 36cf940..fce1a49 100644
--- a/src/northbridge/intel/sandybridge/Kconfig
+++ b/src/northbridge/intel/sandybridge/Kconfig
@@ -94,11 +94,9 @@
 
 config MMCONF_BASE_ADDRESS
 	hex
-	default 0xf8000000 if USE_NATIVE_RAMINIT
 	default 0xf0000000
 	help
-	  We can optimize the native case but the MRC blob requires it
-	  to be at 0xf0000000.
+	  The MRC blob requires it to be at 0xf0000000.
 
 if USE_NATIVE_RAMINIT
 

-- 
To view, visit https://review.coreboot.org/23490
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d0648fe36c88bd9279ac19e5c710055327599fd
Gerrit-Change-Number: 23490
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180129/8e6cd264/attachment.html>